Ticket #5798 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Some algorithms modify base instrument directly

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Martyn Gigg) (diff)

Some algorithms modify the base instrument directly rather than putting the positions in the parameter map.

Known so far:

  • UpdateInstrumentFromFile
  • LoadDetectorInfo
  • ApplyCalibration

These should be updated to modify the parameter map

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Description modified (diff)

comment:2 Changed 8 years ago by Martyn Gigg

  • Owner set to Martyn Gigg
  • Status changed from new to accepted

comment:3 Changed 8 years ago by Martyn Gigg

Remove modification of base instrument. Refs #5798

These algorithms now only modify the parameter map.

Changeset: 21ed5c82df07743f9754cde090676bc9e939d9ad

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Martyn Gigg

Use instrument not base instrument. Refs #5798

Changeset: a508d0f105077c6891d76937528668ee9b9a35ae

comment:6 Changed 8 years ago by Martyn Gigg

Remove modification of base instrument. Refs #5798

These algorithms now only modify the parameter map.

Changeset: 21ed5c82df07743f9754cde090676bc9e939d9ad

comment:7 Changed 8 years ago by Martyn Gigg

Use instrument not base instrument. Refs #5798

Changeset: a508d0f105077c6891d76937528668ee9b9a35ae

comment:8 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:9 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6644

Note: See TracTickets for help on using tickets.