Ticket #5802 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Fix Q calculation in SofQW3

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: critical Milestone: Release 2.3
Component: Mantid Keywords: PatchCandidate,Released
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The Q calculation in SofQW3 needs to be fixed for indirect instruments. My haste to consolidate the calculation caused it to be incorrect.

Change History

comment:1 Changed 8 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Michael Reuter

Refs #5802. Fixing Q calculation.

Changeset: fdfac921476119ac333e17b7d050f7f53772b4dc

comment:3 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

The code change should look like SofQW2::calculateIndirectQ with the addition of the azimuthal angle (psi).

comment:4 Changed 8 years ago by Michael Reuter

  • Keywords PatchCandidate added

comment:5 Changed 8 years ago by Michael Reuter

Refs #5802. Fixing Q calculation.

Changeset: fdfac921476119ac333e17b7d050f7f53772b4dc

comment:6 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:7 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

It's in the code

comment:8 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6648

Note: See TracTickets for help on using tickets.