Ticket #5828 (closed: fixed)
Files created by SaveGSS with the ExtendedHeader option are not recognised correctly by Load
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Vickie Lynch |
Description (last modified by Russell Taylor) (diff)
Load incorrectly picks LoadAscii for these kinds of files.
Change History
comment:1 Changed 8 years ago by Russell Taylor
- Status changed from new to accepted
- Description modified (diff)
comment:2 Changed 8 years ago by Russell Taylor
Re #5828. Load identifies GSAS files saved with extended headers.
Changeset: 100f3404a48144592f6ca21227c6d9a4809f8c1f
comment:3 Changed 8 years ago by Russell Taylor
Re #5828. Test LoadGSS correctly selected as loader.
Changeset: ff59e05e7a27f9544df5131346d87f95c9b063cd
comment:4 Changed 8 years ago by Russell Taylor
Re #5828. Make log message less alarming.
Changeset: a4052d178dfed28d21e03b9a82b1e4eaecccd085
comment:5 Changed 8 years ago by Russell Taylor
Re #5828. Throw exception if file type is wrong.
Rather than just logging and returning normally.
Changeset: 5c9e3ee19ee9099fee866f94f0103761982355c3
comment:6 Changed 8 years ago by Russell Taylor
Re #5828. Add a unit test for LoadGSS.
Changeset: b43977d3db689b04a1cdd0c4e71cd67b4bd4b69d
comment:7 Changed 8 years ago by Russell Taylor
Re #5828. Loosen exception criteria.
Different exceptions are thrown on Windows vs Linux!
Changeset: 04e6f3fddf59429aa281c87c9262cef9e0ebe70c
comment:8 Changed 8 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
The specific problem identified by this ticket was fixed by a 1-line change in the first commit.
The rest relate to a test for that, the introduction of a rudimentary unit test for LoadGSS and fixes uncovered by that. This algorithm could use some tidying up and better error checking. See also ticket #5965.
comment:9 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:10 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to closed
Load works for POWGEN GSAS files
comment:11 Changed 8 years ago by Russell Taylor
Re #5828. Load identifies GSAS files saved with extended headers.
Changeset: 100f3404a48144592f6ca21227c6d9a4809f8c1f
comment:12 Changed 8 years ago by Russell Taylor
Re #5828. Test LoadGSS correctly selected as loader.
Changeset: ff59e05e7a27f9544df5131346d87f95c9b063cd
comment:13 Changed 8 years ago by Russell Taylor
Re #5828. Make log message less alarming.
Changeset: a4052d178dfed28d21e03b9a82b1e4eaecccd085
comment:14 Changed 8 years ago by Russell Taylor
Re #5828. Throw exception if file type is wrong.
Rather than just logging and returning normally.
Changeset: 5c9e3ee19ee9099fee866f94f0103761982355c3
comment:15 Changed 8 years ago by Russell Taylor
Re #5828. Add a unit test for LoadGSS.
Changeset: b43977d3db689b04a1cdd0c4e71cd67b4bd4b69d
comment:16 Changed 8 years ago by Russell Taylor
Re #5828. Loosen exception criteria.
Different exceptions are thrown on Windows vs Linux!
Changeset: 04e6f3fddf59429aa281c87c9262cef9e0ebe70c
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6674
