Ticket #5833 (closed: wontfix)

Opened 8 years ago

Last modified 5 years ago

Refactor CountEventsInPulses

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Peter Peterson

Description

Some codes in this algorithm should be cleaned up. Add option to compress events.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Wenduo Zhou

Refactor the codes. Refs #5833.

Changeset: 8e33492da21b5a855edb3b5812ebff01f8770fd0

comment:3 Changed 8 years ago by Wenduo Zhou

Add compress events. Refs #5833.

Changeset: 59716c0f88c82e4b38551973e4494d77932c7499

comment:4 Changed 8 years ago by Wenduo Zhou

Refactor the codes. Refs #5833.

Changeset: 8e33492da21b5a855edb3b5812ebff01f8770fd0

comment:5 Changed 8 years ago by Wenduo Zhou

Add compress events. Refs #5833.

Changeset: 59716c0f88c82e4b38551973e4494d77932c7499

comment:6 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:8 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to verify
  • Tester Vickie Lynch deleted

comment:9 Changed 8 years ago by Andrei Savici

  • Status changed from verify to reopened
  • Resolution fixed deleted

Loaded a file (try CNCS in the Autotest data), then run this algorithm 

CountEventsInPulses-[Notice] CountEventsInPulses started
CountEventsInPulses-[Notice] For Each Pulse: Delta T = 0.0166712  Standard deviation = 0.000176651
Segmentation fault (core dumped)

Bin size and tolerance were left empty

comment:10 Changed 8 years ago by Nick Draper

A very similar algorithm was added by Owen in this release as we had missed that this algorithm was available. It is RebinByPulseTimes. It doesn't output event workspaces, always ws2D, but has the current advantage of not crashing.

Also please note that the wiki page for this algorithm is out of date.

comment:11 Changed 8 years ago by Wenduo Zhou

Remove CountEventsInPulses out of build. Refs #5833.

Changeset: 06ba34fd226c228031591cba768fadca9547eb06

comment:12 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

Ticket is closed as 'wont fix' because RebinByPulseTimes has same functionality of this algorithm. How to merge these two similar algorithms will be solved by ticket #6069 in next release.

comment:13 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to wontfix

comment:14 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:15 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:16 Changed 8 years ago by Wenduo Zhou

Remove CountEventsInPulses out of build. Refs #5833.

Changeset: 06ba34fd226c228031591cba768fadca9547eb06

comment:17 Changed 8 years ago by Wenduo Zhou

Remove CountEventsInPulses out of build. Refs #5833.

Changeset: 06ba34fd226c228031591cba768fadca9547eb06

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6679

Note: See TracTickets for help on using tickets.