Ticket #5839 (closed: fixed)
Enable MoveInstrumentComponent to accept fully qualified pathname of component
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | anders.markvardsen@… | Blocked By: | |
| Blocking: | Tester: | Andrei Savici |
Description (last modified by Karl Palmen) (diff)
At present MoveInstrumentComponent cannot move any component in any instrument, because the component name may not be unique (e.g. tube005 in panel03 of WISH). Allowing a fully qualified pathname (delimited by '/') in the Component Name property would enable such a component to be moved.
The fix of ticket #5658, which extends the functionality of Instrument::getComponentByName will be helpful here.
Also related to this ticket is #5659, which would enable a fully qualified pathname to be obtained for a component.
Attachments
Change History
comment:2 Changed 8 years ago by Karl Palmen
- Status changed from new to assigned
- Owner set to Karl Palmen
comment:3 Changed 8 years ago by Karl Palmen
This has already been fixed as a consequence of the fix of ticket #5658. Only comments and documentsation need updating.
A fully qualified pathname is not necessary, steps can be missed out, if uniqueness is preserved. For example "panel03/tube005" for "WISH/panel03/WISHpanel03/tub005" for WISH instrument.
The attached python file will test it. After running, view instrument to verify that one tube as been moved and it is the tube moved by the script.
comment:5 Changed 8 years ago by Karl Palmen
Add unit test and update documentation re #5839
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 903cd751e0178c8b58842d66b8478b48ee851dc8
comment:6 Changed 8 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 8 years ago by Karl Palmen
- Status changed from verify to reopened
- Resolution fixed deleted
comment:9 Changed 8 years ago by Karl Palmen
Python exposure is not necessary to run the attached python script MoveTubeTest.py and therefore no python exposure is needed for this ticket.
comment:11 Changed 8 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:12 Changed 8 years ago by Karl Palmen
Add unit test and update documentation re #5839
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 903cd751e0178c8b58842d66b8478b48ee851dc8
comment:13 Changed 8 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:14 Changed 8 years ago by Andrei Savici
- Status changed from verifying to closed
On the CNCS test file, I was able to move "bank40/eightpack/tube1" component
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6685
