Ticket #5840 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Wrong Tube Moved after Saving in Nexus

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Gesner Passos

Description

If you run the attached python file, you will see that tube_3_5 of door3 has been moved. If this workspace is saved to processed Nexus and the Nexus file is then loaded. The tube_3_5 of door1 is moved (to the correct place).

This requires a version of Mantid in which #5658 is fixed, to enable tube_3_5 of door3 to be moved.

This could be fixed by taking advantage of the fix to #5659 after it has been made.

Attachments

MoveTubeTest.py (253 bytes) - added by Karl Palmen 8 years ago.

Change History

Changed 8 years ago by Karl Palmen

comment:1 Changed 8 years ago by Karl Palmen

  • Status changed from new to assigned
  • Owner set to Karl Palmen

comment:2 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by Karl Palmen

Use getFullName instead of getName in ParameterMap.asString re #5840

This required extending Component::getFullName to IComponent. Also I made a change towards making it visible in Python.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0c03c11a33ff56da59a60cd67e1ac28497b6649b

comment:4 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Karl Palmen

Use getFullName instead of getName in ParameterMap.asString re #5840

This required extending Component::getFullName to IComponent. Also I made a change towards making it visible in Python.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0c03c11a33ff56da59a60cd67e1ac28497b6649b

comment:6 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:7 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

Tested for 5 different MERLIN files and inside windows and ubuntu. The only thing I would say is that is quite time consuming, but this is mainly related to loading MERLIN files. I set up this script:

for names in [r'12968', r'12973', r'12992',r'13253',r'13255']:
	comp_name = 'door3/tube_3_5'
	WS = Load(names)
	comp = WS.getInstrument().getComponentByName(comp_name)
	print comp.getPos()

	# Move Tubexxx of door3 up one metre.
	MoveInstrumentComponent( WS,comp_name,X=0.0,Y=1.0,Z=0.0)
	SaveNexus(WS,r'C:\file.nxs')	
	WS2 = Load(r'C:\file.nxs')
	WS2 = mtd['WS2']
	comp = WS2.getInstrument().getComponentByName(comp_name)
	print comp.getPos()

And it took 9 minutes to finish the whole test.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6686

Note: See TracTickets for help on using tickets.