Ticket #5843 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Improve NOMAD IDF

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Change geometry to be the same as IDL reduction code's geometry and compare with Scan5602_bank4pm.dat-Scan5602_bank5_4pm.dat produced by IDL code. Replace IDF and use that IDF in CalibrateRectangularDetectors.

Change History

comment:1 Changed 8 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Vickie Lynch

Refs #5843 Use default IDF for calibration

Changeset: a10b66567a28e8530df7c585b91b655c47f97b34

comment:3 Changed 8 years ago by Vickie Lynch

Refs #5843 calibration changes for NOMAD Changeset: 57fe865ccdd894bd54a6ad02cbd35ba05dd69587

comment:4 Changed 8 years ago by Vickie Lynch

Refs #5843 calibration changes for NOMAD

Changeset: 0536d7991794fad88fed78cf9b21af5bf59da73d

comment:5 Changed 8 years ago by Vickie Lynch

Refs #5843 specify path of IDF

Changeset: 6643069c7266b63dbaaed361c0dc587c687780bb

comment:6 Changed 8 years ago by Vickie Lynch

Refs #5843 Use default IDF for calibration

Changeset: a10b66567a28e8530df7c585b91b655c47f97b34

comment:7 Changed 8 years ago by Vickie Lynch

Refs #5843 only reload instrument for old NOMAD data

Changeset: f65cc21374e25a42bd227994c090ee72335b20e3

comment:8 Changed 8 years ago by Vickie Lynch

Refs #5843 fix if statement

Changeset: 6f33b156aeb5b578b85bf01178893ce616e63afa

comment:9 Changed 8 years ago by Vickie Lynch

Refs #5843 fix path of idf

Changeset: 46c9c07e38b674f15929c811c75625996cfa103c

comment:10 Changed 8 years ago by Peter Peterson

Refs #5843. More work on GetDetOffsetsMultiPeaks for NOMAD data.

Added more criteria for banning peaks from the fit and modified equation being fit.

Changeset: 7d776cefb9469d0c54fff28914343d5ff163ed8c

comment:11 Changed 8 years ago by Peter Peterson

Refs #5843. Fixing unit test.

Algorithm now filters out statistically weak peaks. Bump up the intensity of the model data to meet this requirement.

Changeset: e7b01fea727b4c3004dd227150727ba5dfa011c0

comment:12 Changed 8 years ago by Peter Peterson

Refs #5843. Bug in peak width filter. Added low intensity filter.

The low intensity filter removes peaks whose uncertainties would allow the peak to not exist. This doesn't do terribly much as we already remove peaks with low signal over noise value.

Changeset: 9323873c74df2117a02b9f276f6d76f0e947927e

comment:13 Changed 8 years ago by Russell Taylor

Re #5843. Skip system test overnight until problem is fixed.

Changes introduced in ​https://github.com/mantidproject/mantid/commit/7d776cefb9469d0c54fff28914343d5ff163ed8c cause this test to fail.

Changeset: 5350c3a677c5c3473edf9e490ee1938c6af4db1e

comment:14 Changed 8 years ago by Vickie Lynch

Refs #5843 fix calibration system test

Changeset: e54735a6152625d985a0dbd5f9b6b79b507ebd16

comment:15 Changed 8 years ago by Vickie Lynch

Refs #5843 smooth pixels option for calibration

Changeset: a3a5b96e99efcebeda5143743b8c4deaa806b54c

comment:16 Changed 8 years ago by Vickie Lynch

Refs #5843 correct smoothing for group

Changeset: 43aacbee92e6ea9165234122f7c9ecafe0c6d516

comment:17 Changed 8 years ago by Vickie Lynch

Refs #5843 sort Dreference peaks

Changeset: 138aa3b14f3bb392f49f68362c0717645c5d0207

comment:18 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Calibration results good for groups with low counts

comment:19 Changed 8 years ago by Martyn Gigg

Revert previous commits to fix build. Refs #5843

Changeset: 568f6adedc1f645b3f919d559a90f0afaf52d911

comment:20 Changed 8 years ago by Vickie Lynch

Refs #5843 fix FindPeaks test

Changeset: e4d90381819dfa640c9863c37acbb4ceb8a0bc0d

comment:21 Changed 8 years ago by Russell Taylor

Re #5843. Re-enable test now that it passes.

Revert "Re #5843. Skip system test overnight until problem is fixed."

This reverts commit 5350c3a677c5c3473edf9e490ee1938c6af4db1e.

Changeset: bdf30cc41a770e2f37aeb06de47956f73ff2c3e8

comment:22 Changed 8 years ago by Peter Peterson

Refs #5843. Allow turning off offsets smoothing.

Changeset: 86a904c85627dff56ead574b1b8663e42c495726

comment:23 Changed 8 years ago by Peter Peterson

To test this (somebody at SNS) should run 

LoadCalFile(InstrumentName="NOMAD", CalFilename="/SNS/users/pf9/NOM_calibrate_d9334_2012_11_01.cal", WorkspaceName="NOM")
NOM_9334 = Load("NOM_9334_event.nxs")
NOM_9334 = CompressEvents(NOM_9334, Tolerance=.01)
NOM_9334 = AlignDetectors(InputWorkspace=NOM_9334, OutputWorkspace=NOM_9334, OffsetsWorkspace="NOM_offsets")
NOM_9334 = DiffractionFocussing(NOM_9334, GroupingWorkspace="NOM_group", PreserveEvents=True)
NOM_9334 = ConvertUnits(NOM_9334, Target="MomentumTransfer")
NOM_9334 = Rebin(NOM_9334, Params=(.01, .02, 50.01), PreserveEvents=True)
EditInstrumentGeometry(NOM_9334, SpectrumIDs=(1,2,3,4,5,6), PrimaryFlightPath=19.5, L2=(2,2,2,2,2,2), 
                       Polar=(15,31,67,122,154,7), Azimuthal=(0,0,0,0,0,0))

Joerg1 = LoadAscii("/SNS/NOM/IPTS-4480/shared/Scan9334_Bank000.dat", Unit="MomentumTransfer")
Joerg2 = LoadAscii("/SNS/NOM/IPTS-4480/shared/Scan9334_Bank001.dat", Unit="MomentumTransfer")
Joerg3 = LoadAscii("/SNS/NOM/IPTS-4480/shared/Scan9334_Bank002.dat", Unit="MomentumTransfer")
Joerg4 = LoadAscii("/SNS/NOM/IPTS-4480/shared/Scan9334_Bank003.dat", Unit="MomentumTransfer")
Joerg5 = LoadAscii("/SNS/NOM/IPTS-4480/shared/Scan9334_Bank004.dat", Unit="MomentumTransfer")
Joerg6 = LoadAscii("/SNS/NOM/IPTS-4480/shared/Scan9334_Bank005.dat", Unit="MomentumTransfer")

Then overlay plots of the two different versions.

comment:24 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:25 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

The plots are very similar. Those for banks 1-4 are practically indistinguishable.

comment:26 Changed 8 years ago by Vickie Lynch

Refs #5843 calibration changes for NOMAD

Changeset: 0536d7991794fad88fed78cf9b21af5bf59da73d

comment:27 Changed 8 years ago by Vickie Lynch

Refs #5843 specify path of IDF

Changeset: 6643069c7266b63dbaaed361c0dc587c687780bb

comment:28 Changed 8 years ago by Vickie Lynch

Refs #5843 only reload instrument for old NOMAD data

Changeset: f65cc21374e25a42bd227994c090ee72335b20e3

comment:29 Changed 8 years ago by Vickie Lynch

Refs #5843 fix if statement

Changeset: 6f33b156aeb5b578b85bf01178893ce616e63afa

comment:30 Changed 8 years ago by Vickie Lynch

Refs #5843 fix path of idf

Changeset: 46c9c07e38b674f15929c811c75625996cfa103c

comment:31 Changed 8 years ago by Peter Peterson

Refs #5843. More work on GetDetOffsetsMultiPeaks for NOMAD data.

Added more criteria for banning peaks from the fit and modified equation being fit.

Changeset: 7d776cefb9469d0c54fff28914343d5ff163ed8c

comment:32 Changed 8 years ago by Peter Peterson

Refs #5843. Fixing unit test.

Algorithm now filters out statistically weak peaks. Bump up the intensity of the model data to meet this requirement.

Changeset: e7b01fea727b4c3004dd227150727ba5dfa011c0

comment:33 Changed 8 years ago by Peter Peterson

Refs #5843. Bug in peak width filter. Added low intensity filter.

The low intensity filter removes peaks whose uncertainties would allow the peak to not exist. This doesn't do terribly much as we already remove peaks with low signal over noise value.

Changeset: 9323873c74df2117a02b9f276f6d76f0e947927e

comment:34 Changed 8 years ago by Vickie Lynch

Refs #5843 smooth pixels option for calibration

Changeset: a3a5b96e99efcebeda5143743b8c4deaa806b54c

comment:35 Changed 8 years ago by Vickie Lynch

Refs #5843 correct smoothing for group

Changeset: 43aacbee92e6ea9165234122f7c9ecafe0c6d516

comment:36 Changed 8 years ago by Vickie Lynch

Refs #5843 sort Dreference peaks

Changeset: 138aa3b14f3bb392f49f68362c0717645c5d0207

comment:37 Changed 8 years ago by Martyn Gigg

Revert previous commits to fix build. Refs #5843

Changeset: 568f6adedc1f645b3f919d559a90f0afaf52d911

comment:38 Changed 8 years ago by Vickie Lynch

Refs #5843 fix FindPeaks test

Changeset: e4d90381819dfa640c9863c37acbb4ceb8a0bc0d

comment:39 Changed 8 years ago by Peter Peterson

Refs #5843. Allow turning off offsets smoothing.

Changeset: 86a904c85627dff56ead574b1b8663e42c495726

comment:40 Changed 8 years ago by Peter Peterson

Refs #5843. More work on GetDetOffsetsMultiPeaks for NOMAD data.

Added more criteria for banning peaks from the fit and modified equation being fit.

Changeset: 7d776cefb9469d0c54fff28914343d5ff163ed8c

comment:41 Changed 8 years ago by Peter Peterson

Refs #5843. Fixing unit test.

Algorithm now filters out statistically weak peaks. Bump up the intensity of the model data to meet this requirement.

Changeset: e7b01fea727b4c3004dd227150727ba5dfa011c0

comment:42 Changed 8 years ago by Peter Peterson

Refs #5843. Bug in peak width filter. Added low intensity filter.

The low intensity filter removes peaks whose uncertainties would allow the peak to not exist. This doesn't do terribly much as we already remove peaks with low signal over noise value.

Changeset: 9323873c74df2117a02b9f276f6d76f0e947927e

comment:43 Changed 8 years ago by Vickie Lynch

Refs #5843 smooth pixels option for calibration

Changeset: a3a5b96e99efcebeda5143743b8c4deaa806b54c

comment:44 Changed 8 years ago by Vickie Lynch

Refs #5843 correct smoothing for group

Changeset: 43aacbee92e6ea9165234122f7c9ecafe0c6d516

comment:45 Changed 8 years ago by Vickie Lynch

Refs #5843 sort Dreference peaks

Changeset: 138aa3b14f3bb392f49f68362c0717645c5d0207

comment:46 Changed 8 years ago by Martyn Gigg

Revert previous commits to fix build. Refs #5843

Changeset: 568f6adedc1f645b3f919d559a90f0afaf52d911

comment:47 Changed 8 years ago by Vickie Lynch

Refs #5843 fix FindPeaks test

Changeset: e4d90381819dfa640c9863c37acbb4ceb8a0bc0d

comment:48 Changed 8 years ago by Peter Peterson

Refs #5843. Allow turning off offsets smoothing.

Changeset: 86a904c85627dff56ead574b1b8663e42c495726

comment:49 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6689

Note: See TracTickets for help on using tickets.