Ticket #5846 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Elminate C-style arrays in PeakIntegration

Reported by: Russell Taylor Owned by: Vickie Lynch
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Russell Taylor) (diff)

The sight of something being declared as double ***data frightens me!

More importantly, though, valgrind reports memory leaks coming out of this code and the simplest way to fix this would be to switch to safer C++ constructs such as std::vector and/or boost::scoped_ptr

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Description modified (diff)

comment:2 Changed 8 years ago by Vickie Lynch

Refs #5818 remove unused shoebox integration from PeakIntegration

Changeset: b95e86e2a52e4ee5cd49001eaf458a1b07c191a4

comment:3 Changed 8 years ago by Vickie Lynch

  • Owner set to Vickie Lynch
  • Status changed from new to accepted

comment:4 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

I don't see any more of the scary declarations.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6692

Note: See TracTickets for help on using tickets.