Ticket #5854 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Reconsile MDTransfDEHelper and Kernel::DeltaEMode

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.4
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

The class in Kernel appears which deals with DelteE mode

The class does the same job that MDTransfDEHelper does and though Kernel's class appeared later, it make sense to use one class everywhere.

It can also help to reduce number of parameters in ConvertToMD type of algorithms.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:2 Changed 8 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Alex Buts

comment:3 Changed 8 years ago by Alex Buts

  • Status changed from assigned to accepted

comment:4 Changed 8 years ago by Alex Buts

refs #5854 First stems in removing MDTransfDEHelper

Changeset: 1be64c555c33b1f623bd9fa84fa273391ddb4c63

comment:5 Changed 8 years ago by Alex Buts

refs #5854 Mainly renamed all instances of MDTransfDEHelper

into Kernel::DeltaEMode

Changeset: cf3481f75f82f91efac8469ba426f7a73c704817

comment:6 Changed 8 years ago by Alex Buts

refs #5854 This should finaly get rid of MDTransfDEHelper

Changeset: b2536d04561ebf664513ca011b903ac27b8ff288

comment:7 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester should check and not found any traces of MDTransfDEHelper usage.

The Kernel::DeltaEMode class should be used everywhere where the energy conversion mode is used.

comment:8 Changed 8 years ago by Alex Buts

refs #5854 First stems in removing MDTransfDEHelper

Changeset: 1be64c555c33b1f623bd9fa84fa273391ddb4c63

comment:9 Changed 8 years ago by Alex Buts

refs #5854 Mainly renamed all instances of MDTransfDEHelper

into Kernel::DeltaEMode

Changeset: cf3481f75f82f91efac8469ba426f7a73c704817

comment:10 Changed 8 years ago by Alex Buts

refs #5854 This should finaly get rid of MDTransfDEHelper

Changeset: b2536d04561ebf664513ca011b903ac27b8ff288

comment:11 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:12 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to closed

The only references to MDTransfDEHelper in the code are commented out.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6700

Note: See TracTickets for help on using tickets.