Ticket #5867 (closed: fixed)
Proton charge not calculated correctly in saved nexus files
| Reported by: | Andrei Savici | Owned by: | Andrei Savici |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
For SNS data, the proton charge is in picoCoulombs. If one saves the workspace as a NeXus file, then loads it, when recalculating the total proton charge (i.e. after some filtering) the result is orders of magnitude wrong. This is happening because the SaveNexus/LoadNexus do not carry units around.
Change History
comment:2 Changed 8 years ago by Andrei Savici
For now the units are stored on the NXlog object itself. Will move them to NXlog.value (more functions need to be changed)
comment:3 Changed 8 years ago by Andrei Savici
Add units to logs in Load/Save nexus. Refs #5867
Units are now atributes on the value, not on the NXlog
Changeset: 1f43f668c65e0cf672676361d88c8f87aeaf41d8
comment:6 Changed 8 years ago by Andrei Savici
- Status changed from accepted to verify
- Resolution set to fixed
To test, load the CNCS file, save the workspace to a nexus file, then open the saved nexus. Logs should have units (proton charge is picoCoulombs). Also, if you open it with hdfview, go to logs, and the unit should be an attribute of the value
comment:7 Changed 8 years ago by Andrei Savici
- Status changed from verify to reopened
- Resolution fixed deleted
comment:8 Changed 8 years ago by Andrei Savici
Revert Nexus C++ api. Refs #5867
Changeset: b9d509a1e98ac3a232c8641b3121f8801eb7b103
comment:10 Changed 8 years ago by Andrei Savici
- Status changed from accepted to verify
- Resolution set to fixed
comment:11 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:12 Changed 8 years ago by Michael Reuter
- Status changed from verifying to closed
This works just fine.
comment:13 Changed 8 years ago by Andrei Savici
Add units to logs in Load/Save nexus. Refs #5867
Changeset: 720b80a9ea7a7efe0c4fe5b099f875072fc1c129
comment:14 Changed 8 years ago by Andrei Savici
Add units to logs in Load/Save nexus. Refs #5867
Units are now atributes on the value, not on the NXlog
Changeset: 1f43f668c65e0cf672676361d88c8f87aeaf41d8
comment:15 Changed 8 years ago by Andrei Savici
Revert Nexus C++ api. Refs #5867
Changeset: b9d509a1e98ac3a232c8641b3121f8801eb7b103
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6713
Add units to logs in Load/Save nexus. Refs #5867