Ticket #5871 (closed: fixed)
Refactor TableWS to have pointer to property manager rather then inherit from it
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Release 2.3 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Roman Tolchenov |
Description
According to developer's discussion, it is more reasonable to have property manager as a pointer in TableWorkspace rather then TableWS inheriting form it
(Table ws is not a set of properties)
Change History
comment:2 Changed 8 years ago by Alex Buts
refs #5871 Run separated into LogManager and Run itself
Changeset: 0a971db77d1d97c036abc254cdaedb3765fd4fab
comment:3 Changed 8 years ago by Alex Buts
refs #5871 Tests and final separation of Run
into Run and LogManager
Changeset: 66d24a5935db8f12ab0b8b0424911b2826e97712
comment:4 Changed 8 years ago by Alex Buts
refs #5871 some temporary code returned back
Changeset: bdcff210db381e297b69377c8748d8dafacba8aa
comment:5 Changed 8 years ago by Alex Buts
refs #5871 fixing MAC warnings
Changeset: 8e76a53f5c3a777ba9fe66c06e6b41ef9eac06ec
comment:6 Changed 8 years ago by Alex Buts
refs #5871 fixing MAC error
Changeset: 54aa8fcbefe0c143b5675e1971e76240ea62c232
comment:7 Changed 8 years ago by Alex Buts
refs #5871 this should fix it
+ minor modifications to logManager&Run to avoid "hiden funtcion" warnings.
Changeset: 3b3a0b93a75d11a570e7e986ad4cf8b454eb1d6b
comment:8 Changed 8 years ago by Martyn Gigg
Initialize Workspace in ITableWorkspace constructor. Refs #5871
In the process several implementations have been moved out of the header where they didn't belong
Changeset: 5e0df41fea1d525f9be6e9341f617fee7d6ab822
comment:9 Changed 8 years ago by Alex Buts
refs #5871 Correct clone operation
Changeset: 915fc03626f2f562be89253a569962fb089a28d7
comment:10 Changed 8 years ago by Alex Buts
refs #5871 moved property manager pointer to tableWS
instead of ITableWorkspace.h
Changeset: 89b8728322b9cec5ef5f27fc9b347de5357fec0d
comment:11 Changed 8 years ago by Alex Buts
refs #5871 Moved LogManager pointer from ITableWS to Table WS
and all unintended consequences for this. (nasty)
Changeset: 7031e83e11394aa65b462fc171af174fe3422ea9
comment:12 Changed 8 years ago by Alex Buts
refs #5871 Merging with Base
and making copy constructor for table workspace private (the clone method exist)
Changeset: 26f16f2ea2b0c6f4b300e46743d64421f84cdd7b
comment:13 Changed 8 years ago by Alex Buts
The problem appears more complex then initially thought.
The Table workspace has pointer to the LogManager which is the part of the Run class. The Run has to be split into parts now and new methods logs and getLogs on Table workspace give access to this class.
Unexpected consequence come in providing these methods for PeakWorkspace which is an ITable workspace. Run in PeakWorkspace is accessed through the cowPtr and logs and getLog have to convert cowPtr into shared_ptr. This is non-trivial and non-standard conversion, so the methods doing that should be probably better avoided.
Otherwise, the ticket purpose is achieved, so table workspace has LogManager, which allows to access properties.
comment:14 Changed 8 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
comment:15 Changed 8 years ago by Alex Buts
refs #5871 Trying to fix VATES tests
Changeset: a98f6671fd3b35d9cbd3878a8169081502878861
comment:16 Changed 8 years ago by Alex Buts
refs #5871 fixing Vates erros
Changeset: c3f7b3a6ca41083992129d82b0ac012f0e96754b
comment:17 Changed 8 years ago by Alex Buts
refs #5871 fixing VATES build
Changeset: b59fb914ab6b4fd4ace3f466a87db5463e172652
comment:18 Changed 8 years ago by Alex Buts
refs #5871 fixing VATES tests
Changeset: 5968203a59e14045d096b0f88ba7e91b38acd0d5
comment:19 Changed 8 years ago by Russell Taylor
Re #5871. Small changes for efficiency.
Changeset: cab712d05be0e2d0602b3b381c906c6097c693f8
comment:20 Changed 8 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:22 Changed 8 years ago by Alex Buts
refs #5871 Run separated into LogManager and Run itself
Changeset: 0a971db77d1d97c036abc254cdaedb3765fd4fab
comment:23 Changed 8 years ago by Alex Buts
refs #5871 Tests and final separation of Run
into Run and LogManager
Changeset: 66d24a5935db8f12ab0b8b0424911b2826e97712
comment:24 Changed 8 years ago by Alex Buts
refs #5871 some temporary code returned back
Changeset: bdcff210db381e297b69377c8748d8dafacba8aa
comment:25 Changed 8 years ago by Alex Buts
refs #5871 fixing MAC warnings
Changeset: 8e76a53f5c3a777ba9fe66c06e6b41ef9eac06ec
comment:26 Changed 8 years ago by Alex Buts
refs #5871 fixing MAC error
Changeset: 54aa8fcbefe0c143b5675e1971e76240ea62c232
comment:27 Changed 8 years ago by Alex Buts
refs #5871 this should fix it
+ minor modifications to logManager&Run to avoid "hiden funtcion" warnings.
Changeset: 3b3a0b93a75d11a570e7e986ad4cf8b454eb1d6b
comment:28 Changed 8 years ago by Martyn Gigg
Initialize Workspace in ITableWorkspace constructor. Refs #5871
In the process several implementations have been moved out of the header where they didn't belong
Changeset: 5e0df41fea1d525f9be6e9341f617fee7d6ab822
comment:29 Changed 8 years ago by Alex Buts
refs #5871 Correct clone operation
Changeset: 915fc03626f2f562be89253a569962fb089a28d7
comment:30 Changed 8 years ago by Alex Buts
refs #5871 moved property manager pointer to tableWS
instead of ITableWorkspace.h
Changeset: 89b8728322b9cec5ef5f27fc9b347de5357fec0d
comment:31 Changed 8 years ago by Alex Buts
refs #5871 Moved LogManager pointer from ITableWS to Table WS
and all unintended consequences for this. (nasty)
Changeset: 7031e83e11394aa65b462fc171af174fe3422ea9
comment:32 Changed 8 years ago by Alex Buts
refs #5871 Merging with Base
and making copy constructor for table workspace private (the clone method exist)
Changeset: 26f16f2ea2b0c6f4b300e46743d64421f84cdd7b
comment:33 Changed 8 years ago by Alex Buts
refs #5871 Trying to fix VATES tests
Changeset: a98f6671fd3b35d9cbd3878a8169081502878861
comment:34 Changed 8 years ago by Alex Buts
refs #5871 fixing Vates erros
Changeset: c3f7b3a6ca41083992129d82b0ac012f0e96754b
comment:35 Changed 8 years ago by Alex Buts
refs #5871 fixing VATES build
Changeset: b59fb914ab6b4fd4ace3f466a87db5463e172652
comment:36 Changed 8 years ago by Alex Buts
refs #5871 fixing VATES tests
Changeset: 5968203a59e14045d096b0f88ba7e91b38acd0d5
comment:37 Changed 8 years ago by Russell Taylor
Re #5871. Small changes for efficiency.
Changeset: cab712d05be0e2d0602b3b381c906c6097c693f8
comment:38 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6717