Ticket #5878 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Add processing correct EFixed to ConvertToMD algorithm

Reported by: Alex Buts Owned by: Alex Buts
Priority: trivial Milestone: Release 2.3
Component: Mantid Keywords:
Cc: borreguero@… Blocked By:
Blocking: Tester: Andrei Savici

Description

According to user/colleague request, it is easy to add correct EFixed processing to ConvertToMD

-- Algorithm convertToMD is not handling well spectra from indirect data. In particular, method MDWSDescription:getEi() does not read "Efixed" for each detector. Two examples of reading are implemented in ModeratorTzero::CalculateTfLi() or CorrectKiKf::exec().

Could you please amend your algorithm so that it will read the different Efixed for indirect spectra? --

Change History

comment:1 Changed 8 years ago by Alex Buts

refs #5878 PerrocessDetToMD returns Efixed col on request

At least for Direct instrument if requested.

Changeset: f65099683d6ae4d338537300f4434b424f560c9a

comment:2 Changed 8 years ago by Alex Buts

refs #5878 All ConvertToMD methods update eFixed from array if present

Or at least they should.

Changeset: 6aeb3d1e8a73489a1593312e58e6298870644528

comment:3 Changed 8 years ago by Alex Buts

refs #5878 The tests now work

at least the one I've run

Changeset: b94563a1372a10b45779e1a7c78c6b8907341656

comment:4 Changed 8 years ago by Alex Buts

refs #5878 Additional unit tests

and some unit tests moved

Changeset: 3dd8f6136236af68b1a9de2bcafbfbc357120173

comment:5 Changed 8 years ago by Alex Buts

refs #5878 Fixed unit tests

Changeset: 0f7eebb027b94f9a23f53a9baafeb9bc1fb76cfa

comment:6 Changed 8 years ago by Alex Buts

refs #5878 Removed duplicated getEi function

Changeset: 31e6bd8c63023e4c167dcb741fb7a8f39c166d2e

comment:7 Changed 8 years ago by Alex Buts

refs #5878 Minor simplifications to getEi

Changeset: 6a2525517f6ec93260149a32f1ffe204126b23f1

comment:8 Changed 8 years ago by Alex Buts

Theoretically speaking, ConvertToMD indirect transformation plugin should now read information for each detector.

The code from ConvertUnit::exec(), CorrectKiKf::exec() or CalculateTfLi() is used to do that.

Despite this looks like working I have not found any existing example or instrument, which in fact has different Efixed for a detector defined, so Efixed workspace property is used to provide these values.

The tester should find such instrument if one exist and verify how it all works for this instrument.

Last edited 8 years ago by Alex Buts (previous) (diff)

comment:9 Changed 8 years ago by Alex Buts

refs #5878 Fixing CMake error

Changeset: 13ce47410edc8678f79e1611f8070689a5053540

comment:10 Changed 8 years ago by Alex Buts

refs #5878 Trying to fix python test error

Changeset: 2e9f1301dddee146d6672219de03323b196ab5d7

comment:11 Changed 8 years ago by Alex Buts

refs #5878 Fixing Emodes

Changeset: 0b9c2e7a4a26981164bb4dca92b7807244be7d8c

comment:12 Changed 8 years ago by Alex Buts

refs #5878 Fixing Unix warning

Changeset: 7e2f2954822692b419191f2f1930423933f28ceb

comment:13 Changed 8 years ago by Alex Buts

refs #5878 This should fix unix warning.

Changeset: 7d81c1571be4366078bd7e3049a0b6e46baef13e

comment:14 Changed 8 years ago by Alex Buts

  • Status changed from new to accepted

comment:15 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:17 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • type changed from enhancement to defect

The Basis file is in Autotest directory 

Load(Filename='BSS_11841_event.nxs',OutputWorkspace='BSS_11841_event')
ConvertUnits(InputWorkspace='BSS_11841_event',OutputWorkspace='BSS_11841_event',Target='DeltaE',EMode='Indirect')
Rebin(InputWorkspace='BSS_11841_event',OutputWorkspace='BSS_11841_event',Params='-0.2,0.001,0.2',PreserveEvents='0')
SofQW(InputWorkspace='BSS_11841_event',OutputWorkspace='sq',QAxisBinning='0,0.01,3',EMode='Indirect')

ConvertToMD(InputWorkspace='BSS_11841_event',OutputWorkspace='MD',QDimensions='|Q|',dEAnalysisMode='Indirect',MinValues='0,-0.2',MaxValues='2,0.2')

The MD workspace has 0 events.

comment:18 Changed 8 years ago by Alex Buts

refs #5878 Should fix the problem identified by tester

Changeset: 7f08239f40e93f11f58345653e555b07d9f2aaba

comment:19 Changed 8 years ago by Alex Buts

  • Status changed from reopened to accepted

comment:20 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

The changes fix the script above and allow proper account of energy in indirect mode.

The ticket is not so trivial after all.

comment:21 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying

comment:22 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:23 Changed 8 years ago by Alex Buts

refs #5878 PerrocessDetToMD returns Efixed col on request

At least for Direct instrument if requested.

Changeset: f65099683d6ae4d338537300f4434b424f560c9a

comment:24 Changed 8 years ago by Alex Buts

refs #5878 All ConvertToMD methods update eFixed from array if present

Or at least they should.

Changeset: 6aeb3d1e8a73489a1593312e58e6298870644528

comment:25 Changed 8 years ago by Alex Buts

refs #5878 The tests now work

at least the one I've run

Changeset: b94563a1372a10b45779e1a7c78c6b8907341656

comment:26 Changed 8 years ago by Alex Buts

refs #5878 Additional unit tests

and some unit tests moved

Changeset: 3dd8f6136236af68b1a9de2bcafbfbc357120173

comment:27 Changed 8 years ago by Alex Buts

refs #5878 Fixed unit tests

Changeset: 0f7eebb027b94f9a23f53a9baafeb9bc1fb76cfa

comment:28 Changed 8 years ago by Alex Buts

refs #5878 Removed duplicated getEi function

Changeset: 31e6bd8c63023e4c167dcb741fb7a8f39c166d2e

comment:29 Changed 8 years ago by Alex Buts

refs #5878 Minor simplifications to getEi

Changeset: 6a2525517f6ec93260149a32f1ffe204126b23f1

comment:30 Changed 8 years ago by Alex Buts

refs #5878 Fixing CMake error

Changeset: 13ce47410edc8678f79e1611f8070689a5053540

comment:31 Changed 8 years ago by Alex Buts

refs #5878 Trying to fix python test error

Changeset: 2e9f1301dddee146d6672219de03323b196ab5d7

comment:32 Changed 8 years ago by Alex Buts

refs #5878 Fixing Emodes

Changeset: 0b9c2e7a4a26981164bb4dca92b7807244be7d8c

comment:33 Changed 8 years ago by Alex Buts

refs #5878 Fixing Unix warning

Changeset: 7e2f2954822692b419191f2f1930423933f28ceb

comment:34 Changed 8 years ago by Alex Buts

refs #5878 This should fix unix warning.

Changeset: 7d81c1571be4366078bd7e3049a0b6e46baef13e

comment:35 Changed 8 years ago by Alex Buts

refs #5878 Should fix the problem identified by tester

Changeset: 7f08239f40e93f11f58345653e555b07d9f2aaba

comment:36 Changed 8 years ago by Alex Buts

refs #5878 Should fix the problem identified by tester

Changeset: 7f08239f40e93f11f58345653e555b07d9f2aaba

comment:37 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6724

Note: See TracTickets for help on using tickets.