Ticket #5879 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Deploy compiled fortran libraries only on applicable platforms

Reported by: Russell Taylor Owned by: Martyn Gigg
Priority: trivial Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The .pyd/.so files in scripts/Inelastic are applicable only to certain platforms, so should only be added to the install kits for those platforms. This would reduce the size of the install, plus I think I recall seeing runtime log messages about (obviously) not being able to load libraries meant for other platforms.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted
  • Owner set to Martyn Gigg

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Committed against incorrect ticket. Original msg:

Only deploy inelastic fortran pyd on supported platforms. Refs #5789

Changeset: c549476df2d2b54071fd587d5dff96b296c6276a

comment:3 Changed 8 years ago by Martyn Gigg

Tester: Check that the scripts/Inelastic directory only has files on the Windows XP platform. Also check that the Indirect Data Analyis interface still works.

comment:4 Changed 8 years ago by Russell Taylor

Re #5879. Fix typos in if-else clauses.

They led to the scripts directory not making it into an install apart from 64 bit windows. This was shown up when the system tests turned red.

Changeset: 71820ddac68185064a8a97533c9a90c2c8227d78

comment:5 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:6 Changed 8 years ago by Alex Buts

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • Milestone changed from Release 2.3 to Release 2.4

it still puts *.so libraries in the installation directory of win32 but win64 is seems fine.

Last edited 8 years ago by Alex Buts (previous) (diff)

comment:7 Changed 8 years ago by Russell Taylor

Re #5879. Fix typos in if-else clauses.

They led to the scripts directory not making it into an install apart from 64 bit windows. This was shown up when the system tests turned red.

Changeset: 71820ddac68185064a8a97533c9a90c2c8227d78

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:9 Changed 8 years ago by Martyn Gigg

Ignore .so files on win64. Refs #5879

Changeset: 7b1379b5f58539f72df216406ec44d74b16b91ea

comment:10 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Martyn Gigg

Ignore .so files on win64. Refs #5879

Changeset: 034b433dec533166e70e495cfb7aee9234054a41

comment:12 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester changed from Alex Buts to Russell Taylor

comment:13 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

Verified by inspecting install manifests of latest nightly release builds.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6725

Note: See TracTickets for help on using tickets.