Ticket #5881 (closed: fixed)
Rotate data to sample frame from ConvertToMD
Reported by: | Michael Reuter | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Release 2.3 |
Component: | VATES | Keywords: | |
Cc: | saviciat@… | Blocked By: | |
Blocking: | Tester: | Andrei Savici |
Description
The ConvertToMD algorithm does a good job at creating lab-frame (no goniometer, no UB) data and lattice (goniometer, UB) data, but it does not have an option to create sample-frame (goniometer, no UB) data. It would be beneficial to have this mode as the UB is not always known before processing.
Change History
comment:1 Changed 8 years ago by Alex Buts
- Status changed from new to accepted
- type changed from enhancement to defect
comment:2 Changed 8 years ago by Alex Buts
refs #5881 This should fix it
But more checks are needed.
Changeset: 023f5fba43526fe1b3dbf863e13a3eb69773f729
comment:3 Changed 8 years ago by Alex Buts
refs #5881 Sample frame has been separated as an option.
Changeset: 0231a6a6e403d0bea0560b8743b708c968ec0400
comment:4 Changed 8 years ago by Alex Buts
refs #5881 Tests to check if all goes right
Changeset: 9d2d646272fc5b4ae3c569708044826849f8b04a
comment:5 Changed 8 years ago by Alex Buts
refs #5881 fixing unit test
Changeset: f1130ab8fb4121e03ddd40b31668f40468b180d5
comment:6 Changed 8 years ago by Alex Buts
The logic before new implementation is as follows. The algorithm assumes that
if no UB matrix is found in WS or if it is UB == UnitMatrix and if the goniometer returns UNIT matrix == it is LabFrame
if Goniometer !=Unit matrix but still no UB/UnitUB -- it is SampleFrame
and if UB is present and not unit matrix == it is HKL type target coordinate system
Test testFindTargetFrame verifies this logic.
I hope this logic is satisfactory, though additional property can be easy added to workspace forcing any other coordinate system.
Tester should check if this approach is correct.
He also should check if the whole algorithm returns the result which look satisfactory. (e.g. on data like CNCS_7860_event)
comment:7 Changed 8 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
comment:8 Changed 8 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:9 Changed 8 years ago by Andrei Savici
- Status changed from verifying to closed
Seems to be working. Labels change from Q_lab to Q_sample when I add goniometer
comment:10 Changed 8 years ago by Alex Buts
refs #5881 This should fix it
But more checks are needed.
Changeset: 023f5fba43526fe1b3dbf863e13a3eb69773f729
comment:11 Changed 8 years ago by Alex Buts
refs #5881 Sample frame has been separated as an option.
Changeset: 0231a6a6e403d0bea0560b8743b708c968ec0400
comment:12 Changed 8 years ago by Alex Buts
refs #5881 Tests to check if all goes right
Changeset: 9d2d646272fc5b4ae3c569708044826849f8b04a
comment:13 Changed 8 years ago by Alex Buts
refs #5881 fixing unit test
Changeset: f1130ab8fb4121e03ddd40b31668f40468b180d5
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6727
This is actually the bug. It should work without UB matrix by setting it to I