Ticket #5887 (closed: fixed)
FileProperty::isValid does not return correct value for save types
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Roman Tolchenov |
Description
The isValid member doesn't take into account whether the current value is empty and returns valid for an empty string regardless of the optional status
Change History
comment:2 Changed 8 years ago by Martyn Gigg
Override PropertyWithValue::isValid in FileProperty. Refs #5887
This takes into account empty strings.
Changeset: ee5117743371b765193755f57e5160955690363d
comment:3 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 8 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
Sorry Martyn but the commit here breaks system tests so I'm going to revert it for now.
comment:5 Changed 8 years ago by Russell Taylor
Revert "Override PropertyWithValue::isValid in FileProperty. Refs #5887"
This commit breaks the LOQBatch & SANS2DBatch system tests. This reverts commit ee5117743371b765193755f57e5160955690363d.
Changeset: 4b22bd795424327683dd72b327fdfc55d422d2c2
comment:6 Changed 8 years ago by Martyn Gigg
Put back changes to FileProperty::isValid. Refs #5887
Some property orders in C++ have been altered such that the order in Python stay the same.
Changeset: b64763251c5d6da59ccdcb6704081d1e44a12cc5
comment:8 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:9 Changed 8 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:10 Changed 8 years ago by Roman Tolchenov
- Status changed from verifying to closed
Tested on SaveNexus: an empty string for the output file name triggers a "No file specified" error message. SCDCalibratePanels allows empty string for its optional file name properties.
comment:11 Changed 8 years ago by Martyn Gigg
Override PropertyWithValue::isValid in FileProperty. Refs #5887
This takes into account empty strings.
Changeset: ee5117743371b765193755f57e5160955690363d
comment:12 Changed 8 years ago by Russell Taylor
Revert "Override PropertyWithValue::isValid in FileProperty. Refs #5887"
This commit breaks the LOQBatch & SANS2DBatch system tests. This reverts commit ee5117743371b765193755f57e5160955690363d.
Changeset: 4b22bd795424327683dd72b327fdfc55d422d2c2
comment:13 Changed 8 years ago by Martyn Gigg
Put back changes to FileProperty::isValid. Refs #5887
Some property orders in C++ have been altered such that the order in Python stay the same.
Changeset: b64763251c5d6da59ccdcb6704081d1e44a12cc5
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6733
