Ticket #5896 (closed: fixed)
Add ability to reduce live data via ORNL SANS/DGS/Reflectometry gui
Reported by: | Russell Taylor | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | blocker | Milestone: | Release 2.6 |
Component: | Direct Inelastic | Keywords: | LiveData |
Cc: | Blocked By: | ||
Blocking: | Tester: | Andrei Savici |
Description (last modified by Russell Taylor) (diff)
The idea is to add a 'live' button that will execute essentially the same reduction as in the offline case, taking applicable options from the gui tabs.
This work will initially take place on a branch.
Change History
comment:2 Changed 8 years ago by Russell Taylor
Re #5896. Add a live button to the gui and some early plumbing.
The live reduction to run is hardcoded for now, but is in the right place such that different instruments can kick off different reductions (for now, pressing the live button when not in the EQSANS environment will raise and error).
Changeset: e460d6eec329920b25f3250812cb092182f70040
comment:3 Changed 8 years ago by Russell Taylor
Re #5896. Add hardcoded HYSPEC example.
Changeset: 67485ffa8119c1e386a2026be76a42fb31ab1c89
comment:4 Changed 8 years ago by Russell Taylor
Re #5896. Reduce the number of plots thrown up.
Changeset: cf12a22a56b928a9f34bd2a8dc49bea1af47e7dc
comment:5 Changed 8 years ago by Russell Taylor
Re #5896. Add a live button to the gui and some early plumbing.
The live reduction to run is hardcoded for now, but is in the right place such that different instruments can kick off different reductions (for now, pressing the live button when not in the EQSANS environment will raise and error).
Changeset: 052f254bebd34bff375ad0dfe01949c0639b9687
comment:6 Changed 8 years ago by Russell Taylor
Re #5896. Add hardcoded HYSPEC example.
Changeset: d738c1a302bf42aeb3c5c0cc04fe8c9a419392ae
comment:7 Changed 8 years ago by Russell Taylor
Re #5896. Reduce the number of plots thrown up.
Changeset: 93e3426ac20f34367c98cfe56479057b75028db6
comment:10 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.3.1
moved to patch release
comment:11 Changed 8 years ago by Russell Taylor
- Keywords PatchCandidate removed
- Milestone changed from Release 2.3.1 to Release 2.4
It ain't gonna happen on the timescale given for this patch release.
comment:13 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:14 Changed 7 years ago by Russell Taylor
Re #5896. Remove calls to deprecated method that does nothing.
Changeset: dcfe2f281efc1e70c327a8d2a20e1b1a07549150
comment:15 Changed 7 years ago by Russell Taylor
Re #5896. First try at adding a live button to the DGS reduction GUI.
Uses some nasty tricks at the moment, which should go away as things are generalised for this to be a feature of the whole reduction framework.
Changeset: 32e9e58b629b241ba7ed01e69e0cca41e2977e4e
comment:16 Changed 7 years ago by Russell Taylor
Re #5896. Uncomment the live listener address for HYSPEC.
Changeset: 6e309af51b4aef492bb74bd0ce1456fe1201039f
comment:17 Changed 7 years ago by Russell Taylor
Re #5896. Remove calls to deprecated method that does nothing.
Changeset: dcfe2f281efc1e70c327a8d2a20e1b1a07549150
comment:18 Changed 7 years ago by Russell Taylor
Re #5896. First try at adding a live button to the DGS reduction GUI.
Uses some nasty tricks at the moment, which should go away as things are generalised for this to be a feature of the whole reduction framework.
Changeset: 32e9e58b629b241ba7ed01e69e0cca41e2977e4e
comment:19 Changed 7 years ago by Russell Taylor
Re #5896. Uncomment the live listener address for HYSPEC.
Changeset: 6e309af51b4aef492bb74bd0ce1456fe1201039f
comment:20 Changed 7 years ago by Ruth Mikkelson
Merge branch 'feature/6840_errors' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:21 Changed 7 years ago by Ruth Mikkelson
Merge branch 'feature/6840_errors' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:22 Changed 7 years ago by Russell Taylor
Revert "Re #5896. First try at adding a live button to the DGS reduction GUI."
I'm going to do things a different way.
This reverts commit 32e9e58b629b241ba7ed01e69e0cca41e2977e4e.
Changeset: 4e1e0e7bed5faab0bd9393e7d12aa3496bd82d57
comment:25 Changed 7 years ago by Russell Taylor
- Status changed from new to inprogress
Re #5896. Remove calls to deprecated method that does nothing.
Changeset: c4bcea4c4b83ac830aa22a8bbc57f1482a5d75c7
comment:26 Changed 7 years ago by Russell Taylor
Re #5896. Don't expose to python things that can be set via properties
For things that have been declared via Q_PROPERTY on the C++ side, we can use setProperty to set them and keep the number of methods explicitly exposed to python to a minimum.
Changeset: 3332340fbe57d485f0fd49f823250674a23fb779
comment:27 Changed 7 years ago by Russell Taylor
Re #5896. Add live button to DGS Reduction GUI.
Includes adding infrastructure to do it more generally in these python interfaces.
Changeset: ab947af613a2101d35ecfc302cdbf3db91cf7785
comment:29 Changed 7 years ago by Russell Taylor
Re #5896. Use new-style PyQt signal-slot connection syntax.
Changeset: c7ebf9a9a834ed3bbedadf0c04428f7ac7280ab9
comment:30 Changed 7 years ago by Russell Taylor
Re #5896. A mechanism to change settings when live button is pressed.
Some settings are not applicable or need to have certain values for live reduction. This allows other settings (even in different tabs) to be set or disabled when the live button is pressed.
Changeset: f0aa8d9a54d67489d6272a68ef60c646c6ade4c0
comment:31 Changed 7 years ago by Russell Taylor
Re #5896. Fix certain settings in DGS gui when live button pressed.
This fixes the values of certain aspects and disables the gui elements when the live button is depressed. Any changed settings are remembered and reverted when the button is unchecked.
Changeset: 4225133c46723ba5ca00342ee7952ec08294caa6
comment:32 Changed 7 years ago by Russell Taylor
Re #5896. Spelling correction.
Changeset: bd1fbe5cd1dc2cf80ad3dcfab861fe9f42a02e79
comment:33 Changed 7 years ago by Russell Taylor
- Priority changed from major to blocker
- Description modified (diff)
comment:34 Changed 7 years ago by Russell Taylor
Re #5896. Ensure signal is emitted if state changed programatically.
Switch to a signal that is emitted whenever the state of the button changes, not just when it is manually clicked. This ensures that items are properly disabled if the live button starts out checked. It appears to have no negative effect on the Step Scan GUI (which is the other place listening to that signal).
Changeset: a1b299e557bda17f7990c14c33403ff59416269b
comment:35 Changed 7 years ago by Russell Taylor
Re #5896. Check if default instrument same as GUI instrument.
Unfortunately, because the GUI framework uses it's own setting for what instrument it's dealing with, the live button can only be available if that matches the user's default instrument (as that's the one MWRunFiles checks for).
Changeset: d3365b211f70ecfbda0557a05dd28e0f6103ca2e
comment:36 Changed 7 years ago by Russell Taylor
Re #5896. Use user-supplied workspace name for output.
Also put in code to get around the problem that only the first live chunk will have an entry in the EnergyRequest log. For subsequent chunks we have to copy it from the processed workspace.
This code will need cleaning up later. Probably some will be pushed up to a higher layer and perhaps the output workspace can go in the GeneralSettings so that we don't have to go fishing for it.
Changeset: c55edb2ca9e8def5c3adbf65fc2de5799bd306b9
comment:37 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Although the mechanism has been put into the GUI framework, only the DGS GUI has had a live button added thus far (as only HYSPEC & SEQUOIA have ADARA).
Michael or Andrei should test this ticket as they intimately know their way around this GUI. You'll need to be on a machine that can 'see' the HYSPEC and/or SEQUOIA live streams. You also have to have your default instrument set to the one you're working with.
comment:38 Changed 7 years ago by Russell Taylor
- Component changed from Framework to Direct Inelastic
comment:40 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:41 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/5896_reduction_gui_live_again'
comment:42 Changed 7 years ago by Andrei Savici
It should be tested again next week, when there is beam. I was not able to test that it reads the incident energy guess from the live stream
comment:43 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6742