Ticket #5900 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Critical IDF code not tested

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #5912, #5914, #5915 Tester: Michael Reuter

Description

We have some important behaviour in the InstrumentDefinitionParser, which controls when to read from a vtp file, and when a new one must be generated. There are some other key pieces of logic and associated rules.

If this breaks, it will be very painful to fix. Lets properly unit test this behaviour to avoid that avenue.

Change History

comment:1 Changed 8 years ago by Owen Arnold

refs #5900. Virtual File Object.

Changeset: 5da98ba0ba58c290322c51190ae3c5401ef1660b

comment:2 Changed 8 years ago by Owen Arnold

refs #5900. Work with VirtualFileObject.

Work with VirtualFileObject, and hence can test logic of file caching decisions

Changeset: 5745e372f5664661f5999077cc583ca642feb8ea

comment:3 Changed 8 years ago by Anders Markvardsen

  • Blocking 5912 added

comment:4 Changed 8 years ago by Anders Markvardsen

  • Blocking 5914 added

comment:5 Changed 8 years ago by Anders Markvardsen

  • Blocking 5915 added

comment:6 Changed 8 years ago by Owen Arnold

refs #5910 #5900. ScopedFile.

This will be used in the IDF refactoring tests quite heavily too.

Changeset: 92ff1396d2978cf8a3c2d2b9b02358f8070546a6

comment:7 Changed 8 years ago by Owen Arnold

refs #5910 #5900. Refactor Geom tests to use ScopedFile.

Changeset: ef78e27e9c48c85062eb8f7fa082197b6d2b97cd

comment:8 Changed 8 years ago by Owen Arnold

refs #5900. Extra test post review.

Changeset: 78e7de08a0d2504c8cd8664d2e8c984da01359b5

comment:9 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:10 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC include path error.

Changeset: 117ad6d072ae353e9436faac246918d98ad4cc96

comment:11 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC warnings.

Changeset: 8c44890b9b97cd8bb81b600a12f21c9b1ba3fef9

comment:12 Changed 8 years ago by Owen Arnold

refs #5900. Fix test error.

Changeset: 60450789f29fc3164c9667b74641dd0202ba8d13

comment:13 Changed 8 years ago by Owen Arnold

refs #5900. Fix test build gcc

Changeset: 2c487e41b1aa8344ede22bf640ee1537e7284894

comment:14 Changed 8 years ago by Owen Arnold

refs #5900. Virtual File Object.

Changeset: 70ee19bfc72071b5b639c85ae53566b060764022

comment:15 Changed 8 years ago by Owen Arnold

refs #5900. Work with VirtualFileObject.

Work with VirtualFileObject, and hence can test logic of file caching decisions

Changeset: 3af14a7c199365360d0857683ebbd8e6d69f46a6

comment:16 Changed 8 years ago by Owen Arnold

refs #5910 #5900. ScopedFile.

This will be used in the IDF refactoring tests quite heavily too.

Changeset: 9b08684a0389215a165daee29742e751447cd063

comment:17 Changed 8 years ago by Owen Arnold

refs #5910 #5900. Refactor Geom tests to use ScopedFile.

Changeset: 7be5bdb69fe48e733dd60ef6c4af88632138166b

comment:18 Changed 8 years ago by Owen Arnold

refs #5900. Extra test post review.

Changeset: dc6d2b6cacf13457a5969de3af6601ec5bf58327

comment:19 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC include path error.

Changeset: 39b5950c8e0a6635fb6aa54e443189df79c9a48f

comment:20 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC warnings.

Changeset: 33649cef02937eced033d21a47348dea4588042e

comment:21 Changed 8 years ago by Owen Arnold

refs #5900. Fix test error.

Changeset: 89c313c55ac3c6d7fff55b3884b55823300f3381

comment:22 Changed 8 years ago by Owen Arnold

refs #5900. Fix test build gcc

Changeset: 57566a7f2d1605ab59a9768b0864d9ee2565817c

comment:23 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC warnings

Changeset: b63c34da572527ad4d799f49cc1e3c570b00a369

comment:24 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: I added some additional unit tests to InstrumentDefinitionParserTest to verify the file usage behavior of InstrumentDefinitionParser. Aside from those looking okay, all unit tests and system tests should still be passing.

comment:25 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:26 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This looks fine.

comment:27 Changed 8 years ago by Owen Arnold

refs #5900. Virtual File Object.

Changeset: 70ee19bfc72071b5b639c85ae53566b060764022

comment:28 Changed 8 years ago by Owen Arnold

refs #5900. Work with VirtualFileObject.

Work with VirtualFileObject, and hence can test logic of file caching decisions

Changeset: 3af14a7c199365360d0857683ebbd8e6d69f46a6

comment:29 Changed 8 years ago by Owen Arnold

refs #5910 #5900. ScopedFile.

This will be used in the IDF refactoring tests quite heavily too.

Changeset: 9b08684a0389215a165daee29742e751447cd063

comment:30 Changed 8 years ago by Owen Arnold

refs #5910 #5900. Refactor Geom tests to use ScopedFile.

Changeset: 7be5bdb69fe48e733dd60ef6c4af88632138166b

comment:31 Changed 8 years ago by Owen Arnold

refs #5900. Extra test post review.

Changeset: dc6d2b6cacf13457a5969de3af6601ec5bf58327

comment:32 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC include path error.

Changeset: 39b5950c8e0a6635fb6aa54e443189df79c9a48f

comment:33 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC warnings.

Changeset: 33649cef02937eced033d21a47348dea4588042e

comment:34 Changed 8 years ago by Owen Arnold

refs #5900. Fix test error.

Changeset: 89c313c55ac3c6d7fff55b3884b55823300f3381

comment:35 Changed 8 years ago by Owen Arnold

refs #5900. Fix test build gcc

Changeset: 57566a7f2d1605ab59a9768b0864d9ee2565817c

comment:36 Changed 8 years ago by Owen Arnold

refs #5900. Fix GCC warnings

Changeset: b63c34da572527ad4d799f49cc1e3c570b00a369

comment:37 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6746

Note: See TracTickets for help on using tickets.