Ticket #5903 (closed: fixed)
Templated TimeSeriesProperty::getTotalValue makes no sense for some types
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Alex Buts |
Description
E.g. bool & string.
Given that it's only called in a single place in the entire codebase, where the type of the property is always a double, I'm going to delete the method and put the logic in the calling location.
Change History
comment:1 Changed 8 years ago by Russell Taylor
- Status changed from new to accepted
- Owner set to Russell Taylor
comment:2 Changed 8 years ago by Russell Taylor
Re #5903. Remove TimeSeriesProperty::getTotalValue method.
It makes no sense for some property types (bool, string) and is only used once.
Changeset: e6bb640c0f1a7a046ab743557d53bb9e5e52d772
comment:3 Changed 8 years ago by Russell Taylor
- Priority changed from major to minor
- Status changed from accepted to verify
- Resolution set to fixed
It's not very efficient to use the valuesAsVector method, but see #5902 which should deal with that.
comment:4 Changed 8 years ago by Alex Buts
- Status changed from verify to verifying
- Tester set to Alex Buts
comment:5 Changed 8 years ago by Alex Buts
- Status changed from verifying to closed
Overloading templated class function for output value/input type (it is possible for not class functions but I did not found right syntax(solution?) for a templated class function) would be more interesting solution, but this solution is fair enough.
comment:6 Changed 8 years ago by Russell Taylor
Re #5903. Remove TimeSeriesProperty::getTotalValue method.
It makes no sense for some property types (bool, string) and is only used once.
Changeset: e6bb640c0f1a7a046ab743557d53bb9e5e52d772
