Ticket #5905 (closed: wontfix)

Opened 8 years ago

Last modified 5 years ago

fetch_Third_Party.bat fails for new version of git Git-1.7.11

Reported by: Gesner Passos Owned by: Peter Parker
Priority: minor Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Dan Nixon) (diff)

The new versions of Git, at least, Git-1.7.11 for windows, does not provide the git.cmd anymore. It has only the git.exe. It is enough to replace git.cmd to git.

Another minor issue, is that when you try to execute the bat script, if it fails, it will close without giving you feedback why it closed. Is it possible to set up that the bash screen do not close in case of failure?

Attachments

fetch.patch​ (3.1 KB) - added by Gesner Passos 8 years ago.
Patch file that does the replacement of git.cmd to git

Change History

Changed 8 years ago by Gesner Passos

Patch file that does the replacement of git.cmd to git

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:4 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:7 Changed 6 years ago by Dan Nixon

  • Owner changed from Anyone to Dan Nixon
  • Description modified (diff)

comment:8 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Updated fetch 3rd party script re #5905

Added pause to ensure terminal window does not close Switched from git.cmd to git

Changeset: 28eee8468fa98c94c0722f7febd9e2d03970db19

comment:9 Changed 6 years ago by Dan Nixon

Still need the exits in there

Refs #5905

Changeset: c6ad63bc6e2409d420bac4c0cf475f9564cb507d

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Peter Parker

  • Milestone changed from Backlog to Release 3.3

comment:12 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:13 Changed 6 years ago by Peter Parker

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Martyn has confirmed that the introduction of pause statements will cause problems where we run this in our automated builds, and also that the changes surrounding git.cmd are now no longer necessary.

Essentially this means that this ticket is now void. Sorry for the wasted effort, Dan.

comment:14 Changed 6 years ago by Peter Parker

  • Status changed from reopened to verify
  • Owner changed from Dan Nixon to Peter Parker
  • Resolution set to wontfix

comment:15 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Peter Parker to Martyn Gigg

comment:16 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6751

Note: See TracTickets for help on using tickets.