Ticket #5912 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Removing <defaults> section in IDF cause crash

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: owen.arnold@… Blocked By: #5900
Blocking: Tester: Owen Arnold

Description

This ticket should not be completed before #5900 has been completed.

The attached IDF_minimalistic.xml file contains an instrument which can be loaded successfully with LoadEmptyInstrument.

However if the element <defaults>

</defaults> is removed in this IDF MantidPlot crashes trying to subsequently load it.

Change this so that silently it is accepted that a <defaults> element is not present in the IDF

Attachments

IDF_minimalistic.xml (678 bytes) - added by Anders Markvardsen 8 years ago.

Change History

Changed 8 years ago by Anders Markvardsen

comment:1 Changed 8 years ago by Karl Palmen

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Karl Palmen

Make readDefaults return if supplied null argument re #5912

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ffb34f24a01c3d33c6496767441d1b68bc108549

comment:3 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

MantidPlot doesn't crash after removing the Defaults sections.

comment:6 Changed 8 years ago by Karl Palmen

Make readDefaults return if supplied null argument re #5912

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ffb34f24a01c3d33c6496767441d1b68bc108549

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6758

Note: See TracTickets for help on using tickets.