Ticket #5914 (closed: fixed)
When idlist missing for a component in IDF
| Reported by: | Anders Markvardsen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | owen.arnold@… | Blocked By: | #5900 |
| Blocking: | Tester: | Nick Draper |
Description
This ticket should not be completed before #5900 has been completed.
The attached IDF_minimalistic.xml file contains an instrument which can be loaded successfully with LoadEmptyInstrument.
However if the attribute: idlist="cylinder-right" is removed MantidPlot display the warning:
"The number of detector IDs listed in idlist named is less then the number of detectors"
For this case change the warning to "The component blah... contain detectors but has no idlist specified for it"
Attachments
Change History
comment:1 Changed 8 years ago by Anders Markvardsen
- Priority changed from critical to major
- Status changed from new to assigned
- Owner changed from Anders Markvardsen to Karl Palmen
comment:2 Changed 8 years ago by Karl Palmen
This fix requires a unit test based on the attached file.
comment:3 Changed 8 years ago by Karl Palmen
To debug or test, run the LoadEmptyInstrument algorithm on an appropriately modified version of the attached IDF_minimalistic.xml file.
comment:4 Changed 8 years ago by Karl Palmen
Improve error messages when detector list is not OK re #5914
Changeset: 9492c8c6d3760f285073affd821bfca0f00e2c22
comment:5 Changed 8 years ago by Karl Palmen
Tidy up error messaging re #5914 re #5915
In particular, LoadEmptyInstrument does not attempt to continue running, if the LoadInstrument sub-algorithm has failed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e27f8d32ad9b180eca51928dcf7c8ec6ed9bf10
comment:6 Changed 8 years ago by Karl Palmen
Change Exception message as well as log message re #5914
This will make unit testing easier.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 39b5095a5135c4542c27bd64b447f3be52e87b5a
comment:7 Changed 8 years ago by Karl Palmen
Add unit test for the case of ticket re #5914
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2044145c10c072e8a7ac27c5313bfa134280f89d
comment:8 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:9 Changed 8 years ago by Karl Palmen
Improve error messages when detector list is not OK re #5914
Changeset: 9492c8c6d3760f285073affd821bfca0f00e2c22
comment:10 Changed 8 years ago by Karl Palmen
Tidy up error messaging re #5914 re #5915
In particular, LoadEmptyInstrument does not attempt to continue running, if the LoadInstrument sub-algorithm has failed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e27f8d32ad9b180eca51928dcf7c8ec6ed9bf10
comment:11 Changed 8 years ago by Karl Palmen
Change Exception message as well as log message re #5914
This will make unit testing easier.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 39b5095a5135c4542c27bd64b447f3be52e87b5a
comment:12 Changed 8 years ago by Karl Palmen
Add unit test for the case of ticket re #5914
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2044145c10c072e8a7ac27c5313bfa134280f89d
comment:14 Changed 8 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:15 Changed 8 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6760
