Ticket #5918 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Parallelize over the boxes instead of events in ResolutionConvolvedModel

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Martyn Gigg) (diff)

This should be much more efficient as it will entail creating fewer threads but each will do more work. Plus MDEventWorkspace is already set up to iterator nicely over the boxes in separated threads

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Description modified (diff)

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Martyn Gigg

Parallelize over boxes in ResolutionConvolvedModel. Refs #5918

This should be more efficient that the original.

Changeset: 0de7de6364f0b2f0d9ebf611c53146dac4cea45a

comment:4 Changed 8 years ago by Martyn Gigg

Diagnosing test. Refs #5918

Changeset: bcfce2ba9029ae42a0fef4eb16009d241f669a4e

comment:5 Changed 8 years ago by Martyn Gigg

Fix ResolutionConvolvedCrossSectionTest on Mac/Win. Refs #5918

Changeset: 4e6817842f7be05fe10ab8c0f69ceebb86541f86

comment:6 Changed 8 years ago by Martyn Gigg

Proper fix for Mac/Win ResolutionConvolvedTest Refs #5918

Changeset: b33b75dae4e29d091114b8bde80275fc6ae6101d

comment:7 Changed 8 years ago by Martyn Gigg

Test not quite right on Windows. Refs #5918

Changeset: 96ab543954e8cf5c3ed11983205569490ecc7772

comment:8 Changed 8 years ago by Martyn Gigg

Fix iteration over boxes in ResolutionConvoledCrossSection. Refs #5918

Works with uneven box distributions now.

Changeset: 724a376ba91700b5bc8093f207779e3e2ed0411f

comment:9 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:11 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

As a ticket itself this is not so testable.

However the model does indeed make full use of all 4 cores on my laptop, and progresses at a reasonable speed.

comment:12 Changed 8 years ago by Martyn Gigg

Parallelize over boxes in ResolutionConvolvedModel. Refs #5918

This should be more efficient that the original.

Changeset: 0de7de6364f0b2f0d9ebf611c53146dac4cea45a

comment:13 Changed 8 years ago by Martyn Gigg

Diagnosing test. Refs #5918

Changeset: bcfce2ba9029ae42a0fef4eb16009d241f669a4e

comment:14 Changed 8 years ago by Martyn Gigg

Fix ResolutionConvolvedCrossSectionTest on Mac/Win. Refs #5918

Changeset: 4e6817842f7be05fe10ab8c0f69ceebb86541f86

comment:15 Changed 8 years ago by Martyn Gigg

Proper fix for Mac/Win ResolutionConvolvedTest Refs #5918

Changeset: b33b75dae4e29d091114b8bde80275fc6ae6101d

comment:16 Changed 8 years ago by Martyn Gigg

Test not quite right on Windows. Refs #5918

Changeset: 96ab543954e8cf5c3ed11983205569490ecc7772

comment:17 Changed 8 years ago by Martyn Gigg

Fix iteration over boxes in ResolutionConvoledCrossSection. Refs #5918

Works with uneven box distributions now.

Changeset: 724a376ba91700b5bc8093f207779e3e2ed0411f

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6764

Note: See TracTickets for help on using tickets.