Ticket #5920 (closed: fixed)
New Python API won't load if pythonalgorithms.directories contains empty directory
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Andrei Savici |
Description
Change History
comment:2 Changed 8 years ago by Martyn Gigg
Protection for empty directory string when loading python Refs #5920
Changeset: 68f33fd2499404805b550139cff4a83afc30c447
comment:3 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 8 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:5 Changed 8 years ago by Russell Taylor
Things are OK if I leave pythonalgorithms.directories empty or add a ; at either end of the usual entry. However, if I add an entry that points to a file rather than a directory I get an error that's coming out of the old api code and python fails to initialize:
File "MantidFramework.py", line 1199, in initialise
plugins = pyalg_loader.load_modules(refresh=False)
File "MantidFramework.py", line 1439, in load_modules
changes, plugins = self._importAlgorithms(path, refresh)
TypeError: 'bool' object is not iterable
Should we fix this?
comment:6 Changed 8 years ago by Russell Taylor
Re #5920. Protect against file being in pythonalgorithms.directories
rather than a directory. Previously, this would stop python initialising in MantidPlot.
Changeset: 61024af775dc264054ea43485d13d43e74f1d147
comment:7 Changed 8 years ago by Russell Taylor
- Status changed from verifying to verify
- Tester Russell Taylor deleted
As I made a change here to address comment:5, this ticket should be independently tested.
comment:8 Changed 8 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:10 Changed 8 years ago by Martyn Gigg
Protection for empty directory string when loading python Refs #5920
Changeset: 68f33fd2499404805b550139cff4a83afc30c447
comment:11 Changed 8 years ago by Russell Taylor
Re #5920. Protect against file being in pythonalgorithms.directories
rather than a directory. Previously, this would stop python initialising in MantidPlot.
Changeset: 61024af775dc264054ea43485d13d43e74f1d147
comment:12 Changed 8 years ago by Russell Taylor
Re #5920. Protect against file being in pythonalgorithms.directories
rather than a directory. Previously, this would stop python initialising in MantidPlot.
Changeset: 61024af775dc264054ea43485d13d43e74f1d147
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6766
