Ticket #5929 (closed: fixed)
VatesAPI not using Algorithm Factory
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | minor | Milestone: | Release 2.3 |
Component: | VATES | Keywords: | |
Cc: | martyn.gigg@… | Blocked By: | |
Blocking: | Tester: | Russell Taylor |
Description
Algorithms generated in the VatesAPI should ALL be generated via the standard factory mechanism. Some seem to have slipped through the net.
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #5929. Refactoring done.
Should have got rid of all all offending algorithm instances
Changeset: db58f424eb2ba5b2b83adb741b4ca53401a906c5
comment:3 Changed 8 years ago by Owen Arnold
- Cc martyn.gigg@… added
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 8 years ago by Owen Arnold
Tester: This is a simple refactoring step. Verify that:
1) The unit tests for the VatesAPI have not been modified as part of this ticket
2) The unit tests for the VatesAPI still pass, as these have good test coverage for this set of modifications.
comment:5 Changed 8 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:6 Changed 8 years ago by Russell Taylor
- Status changed from verifying to closed
Looks good per comment:4
comment:7 Changed 8 years ago by Owen Arnold
refs #5929. Refactoring done.
Should have got rid of all all offending algorithm instances
Changeset: db58f424eb2ba5b2b83adb741b4ca53401a906c5