Ticket #5940 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Fitting using convolution generates warning when using non-constant ties

Reported by: Jose Borreguero Owned by: Jose Borreguero
Priority: trivial Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

When member functions of the convolution composite make use of non-constant ties, a warning is used if non-numerical derivatives are used. However, the convolution composite function does use numerical derivatives

Change History

comment:1 Changed 8 years ago by Jose Borreguero

Refs #5940 set m_useNumericDerivatives to true

modified: Convolution.cpp

Changeset: 3fc5054e67a1e544cb6859578c47e726e977e1aa

comment:2 Changed 8 years ago by Jose Borreguero

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Jose Borreguero

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:5 Changed 8 years ago by Jose Borreguero

Refs #5940 use setAttributeValue

Directly setting m_useNumericDerivatives to true leaves attribute "NumDeriv" as false

modified: ../CurveFitting/src/Convolution.cpp

Changeset: 311640ececbabb835cdd3771da7436489718470f

comment:6 Changed 8 years ago by Jose Borreguero

  • Status changed from reopened to accepted

comment:7 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:9 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Due to the overlapping functionality to set "NumDeriv" and to use function useNumericDerivatives(), it might be better to make useNumericalDerivatives() private?

comment:10 Changed 8 years ago by Jose Borreguero

Refs #5940 set m_useNumericDerivatives to true

modified: Convolution.cpp

Changeset: 3fc5054e67a1e544cb6859578c47e726e977e1aa

comment:11 Changed 8 years ago by Jose Borreguero

Refs #5940 use setAttributeValue

Directly setting m_useNumericDerivatives to true leaves attribute "NumDeriv" as false

modified: ../CurveFitting/src/Convolution.cpp

Changeset: 311640ececbabb835cdd3771da7436489718470f

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6786

Note: See TracTickets for help on using tickets.