Ticket #5948 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

RebinByPulseTimes

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #5985 Tester: Nick Draper

Description

We've recently had some interesting situations with filtering applied to Event workspaces, where it would have been very useful to determine what the Pulse time distribution of events throughout the workspace was.

Create an algorithm that takes an EventWorkspace, rebins the events according to pulse time and generates an output 2D workspace with the X-axis set to be pulse time. In-fact, the x-axis should be in units that users can easily understand. So the x-axis should be in relative time to the start of the run (run_start).

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

It would be good to control the query to a given number of spectra, or range of spectra. This would have been useful for a recent scenario, where pulse times varied across banks owing to buffering in the electronics.

comment:3 Changed 8 years ago by Owen Arnold

refs #5946. Alternative histogramming.

Add the ability to histogram the event list by pulse_time

Changeset: 4d6a2a5991ad702303971a760e0a71a0b873de71

comment:4 Changed 8 years ago by Owen Arnold

refs #5948. Fix warnings

Changeset: bf406db8994041667a8cbb89a50d52dfc284567f

comment:5 Changed 8 years ago by Owen Arnold

refs #5948. Expose histogram by pulse binning.

Changeset: cd787267ee82b9c837a6ebda6756f79b285f36f1

comment:6 Changed 8 years ago by Owen Arnold

refs #5948. Alg can rebin. Rebin looks correct.

Lots more work required here to make the code more robust and properly tested.

Changeset: 2c1200df1ecf1429891e4be280612174acd345ed

comment:7 Changed 8 years ago by Owen Arnold

refs #5948. Test Various binning setups.

Changeset: fdd1c859a61e9374cad595f67d339d13998e2342

comment:8 Changed 8 years ago by Owen Arnold

refs #5948. Test more edge cases.

Changeset: 9d9da99a8a5413c72404dc84a3cd988278fcaf98

comment:9 Changed 8 years ago by Owen Arnold

refs #5948. Inputs and results in relative time.

Changed axis to report in Time unit. Inputs are converted from relative time to absolute time in nanoseconds for the calculation. The xaxis is provided in relative time.

Changeset: 12a0f66faecb97f5dfad2d5d88bb37887285a2df

comment:10 Changed 8 years ago by Owen Arnold

refs #5948. Test offsets are working.

Also improve readability of tests.

Changeset: 400177ede789aa008b4d025ae851e34e75be217f

comment:11 Changed 8 years ago by Owen Arnold

refs #5948. Add performance tests.

Changeset: 7f019b6e27f5a8d222a09876fb1081cdbe4db115

comment:12 Changed 8 years ago by Owen Arnold

refs #5948. Fix GCC errors.

Changeset: 102adfb3ef5f7c008dc7a9f247930f41b901cd98

comment:13 Changed 8 years ago by Owen Arnold

refs #5948. Fix GCC errors. Missing boost include.

Changeset: 120a18e9d4f552cd1c25883780438a0d898eabba

comment:14 Changed 8 years ago by Owen Arnold

refs #5948. Fix rhel6 build.

Changeset: f7b283438e75e89989c6b1bd73e98787aec8c66d

comment:15 Changed 8 years ago by Owen Arnold

refs #5948. Fix rhel6 build.

Changeset: 5dd36ac4c885e56eb2cb35bf0e77ebbaec7e0c9f

comment:16 Changed 8 years ago by Owen Arnold

refs #5948. Fix warnings.

Changeset: 006553b0de701fdb2ac6c0a4beeb20057fe95696

comment:17 Changed 8 years ago by Owen Arnold

refs #5948. Fix more warnings.

Changeset: 9104c583183fa904fd0c2b08905d9bba319cd4c3

comment:18 Changed 8 years ago by Owen Arnold

refs #5948. Fix 32 bit tests.

Changeset: 923de03eece152eb0add1f3fba5fb331ee5e9b75

comment:19 Changed 8 years ago by Owen Arnold

refs #5948. Fix warnings.

Changeset: 67bc53595a67d7c187c3cd9df98e9a72372ac1d8

comment:20 Changed 8 years ago by Owen Arnold

refs #5948. Refactor seam from search.

Changeset: 534ad7bb80fc02e8fcb5b1b136343d0a4b6b9e26

comment:21 Changed 8 years ago by Owen Arnold

refs #5948. Determine Min and Max pulse times.

Changeset: ab2b4dc5278ca36d9652894e4f1119d547be2f5d

comment:22 Changed 8 years ago by Owen Arnold

refs #5948. Use new feature.

Changeset: 271ce49683f7af62054ae337269b391566234749

comment:23 Changed 8 years ago by Owen Arnold

refs #5948. Rename to RebinByPulseTimes.

Changeset: f067ee77dca965297bece1107e95abeecebc3edb

comment:24 Changed 8 years ago by Owen Arnold

  • Summary changed from QueryPulseTimes to RebinByPulseTimes

comment:25 Changed 8 years ago by Owen Arnold

  • Blocking 5985 added

comment:26 Changed 8 years ago by Owen Arnold

refs #5948. Wiki docs and more tests.

Changeset: 0523d0fdafff8f3953ba1b06e7f00c678a033933

comment:27 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: You should easily be able to test this algorithm with an existing TOF event workspace. Check that the rebinning obeys the input parameters provided. Unit tests should also help demonstrate this working well.

comment:28 Changed 8 years ago by Owen Arnold

refs #5948. Fix unused var warning.

Changeset: 2c991fc051b918c3d564ff213ccbb564cdf1d5a3

comment:29 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:30 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

works with ornl and isis event nexus files

comment:31 Changed 8 years ago by Owen Arnold

refs #5948. Fix warnings

Changeset: bf406db8994041667a8cbb89a50d52dfc284567f

comment:32 Changed 8 years ago by Owen Arnold

refs #5948. Expose histogram by pulse binning.

Changeset: cd787267ee82b9c837a6ebda6756f79b285f36f1

comment:33 Changed 8 years ago by Owen Arnold

refs #5948. Alg can rebin. Rebin looks correct.

Lots more work required here to make the code more robust and properly tested.

Changeset: 2c1200df1ecf1429891e4be280612174acd345ed

comment:34 Changed 8 years ago by Owen Arnold

refs #5948. Test Various binning setups.

Changeset: fdd1c859a61e9374cad595f67d339d13998e2342

comment:35 Changed 8 years ago by Owen Arnold

refs #5948. Test more edge cases.

Changeset: 9d9da99a8a5413c72404dc84a3cd988278fcaf98

comment:36 Changed 8 years ago by Owen Arnold

refs #5948. Inputs and results in relative time.

Changed axis to report in Time unit. Inputs are converted from relative time to absolute time in nanoseconds for the calculation. The xaxis is provided in relative time.

Changeset: 12a0f66faecb97f5dfad2d5d88bb37887285a2df

comment:37 Changed 8 years ago by Owen Arnold

refs #5948. Test offsets are working.

Also improve readability of tests.

Changeset: 400177ede789aa008b4d025ae851e34e75be217f

comment:38 Changed 8 years ago by Owen Arnold

refs #5948. Add performance tests.

Changeset: 7f019b6e27f5a8d222a09876fb1081cdbe4db115

comment:39 Changed 8 years ago by Owen Arnold

refs #5948. Fix GCC errors.

Changeset: 102adfb3ef5f7c008dc7a9f247930f41b901cd98

comment:40 Changed 8 years ago by Owen Arnold

refs #5948. Fix GCC errors. Missing boost include.

Changeset: 120a18e9d4f552cd1c25883780438a0d898eabba

comment:41 Changed 8 years ago by Owen Arnold

refs #5948. Fix rhel6 build.

Changeset: f7b283438e75e89989c6b1bd73e98787aec8c66d

comment:42 Changed 8 years ago by Owen Arnold

refs #5948. Fix rhel6 build.

Changeset: 5dd36ac4c885e56eb2cb35bf0e77ebbaec7e0c9f

comment:43 Changed 8 years ago by Owen Arnold

refs #5948. Fix warnings.

Changeset: 006553b0de701fdb2ac6c0a4beeb20057fe95696

comment:44 Changed 8 years ago by Owen Arnold

refs #5948. Fix more warnings.

Changeset: 9104c583183fa904fd0c2b08905d9bba319cd4c3

comment:45 Changed 8 years ago by Owen Arnold

refs #5948. Fix 32 bit tests.

Changeset: 923de03eece152eb0add1f3fba5fb331ee5e9b75

comment:46 Changed 8 years ago by Owen Arnold

refs #5948. Fix warnings.

Changeset: 67bc53595a67d7c187c3cd9df98e9a72372ac1d8

comment:47 Changed 8 years ago by Owen Arnold

refs #5948. Refactor seam from search.

Changeset: 534ad7bb80fc02e8fcb5b1b136343d0a4b6b9e26

comment:48 Changed 8 years ago by Owen Arnold

refs #5948. Determine Min and Max pulse times.

Changeset: ab2b4dc5278ca36d9652894e4f1119d547be2f5d

comment:49 Changed 8 years ago by Owen Arnold

refs #5948. Use new feature.

Changeset: 271ce49683f7af62054ae337269b391566234749

comment:50 Changed 8 years ago by Owen Arnold

refs #5948. Rename to RebinByPulseTimes.

Changeset: f067ee77dca965297bece1107e95abeecebc3edb

comment:51 Changed 8 years ago by Owen Arnold

refs #5948. Wiki docs and more tests.

Changeset: 0523d0fdafff8f3953ba1b06e7f00c678a033933

comment:52 Changed 8 years ago by Owen Arnold

refs #5948. Fix unused var warning.

Changeset: 2c991fc051b918c3d564ff213ccbb564cdf1d5a3

comment:53 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6794

Note: See TracTickets for help on using tickets.