Ticket #5955 (closed: invalid)

Opened 8 years ago

Last modified 5 years ago

Move remaining MD algorithms into MD algorithms

Reported by: Alex Buts Owned by: Alex Buts
Priority: minor Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Nick Draper) (diff)

For historical reasons there are number of MD algorithms (which inherit from Algorithms) which still sit in MDEvents (which is equivalent to Dataobjects) The native place for these algorithms should be MDAlgorithms.

This creates confusion and minor inconveniences.

Change History

comment:1 Changed 8 years ago by Alex Buts

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 8 years ago by Alex Buts

refs #5955 Moved Save/LoadMD and defendants

Changeset: 7b5d2b26ed00a370c28bcfaba8eb7ce79c5e95c0

comment:4 Changed 8 years ago by Alex Buts

refs #5955 fixing VATES

Changeset: 2ddbd69df3dffea461c43c934e7e83f86a66aa36

comment:5 Changed 8 years ago by Alex Buts

refs #5955 fixing Vates

Changeset: f84a717ea7e6d0cf2847c71812ddd31648ed31e7

comment:6 Changed 8 years ago by Alex Buts

refs #5955 Removed MDAlgorithms from VATES dependencies

Changeset: 093541c463b2779e9ff7626ee7d81ce7ccc01b93

comment:7 Changed 8 years ago by Alex Buts

refs #5955 Moved FameMDEventData

Changeset: 09cf8db7fec842b22e11f5331153020043a26d66

comment:8 Changed 8 years ago by Alex Buts

refs #5955 Fixing tests depending on the FakeMDEventsData

Changeset: 06dd4607affe9c33e36070bf9284f62fde4dec39

comment:9 Changed 8 years ago by Alex Buts

refs #5955 Moved CreateMDWorkspace and CreateMDHistoWorkspace

Changeset: 31a90376dcda7439ecba3539e0a480fc68a98fc1

comment:10 Changed 8 years ago by Alex Buts

refs #5955 Fixing build caused by move.

Changeset: 3a01fb796a6875c43ff2475605a005533dabb262

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

moved to Release 2.4

comment:12 Changed 8 years ago by Alex Buts

refs #5955 Moved Save/LoadMD and defendants

Changeset: 7b5d2b26ed00a370c28bcfaba8eb7ce79c5e95c0

comment:13 Changed 8 years ago by Alex Buts

refs #5955 fixing VATES

Changeset: 2ddbd69df3dffea461c43c934e7e83f86a66aa36

comment:14 Changed 8 years ago by Alex Buts

refs #5955 fixing Vates

Changeset: f84a717ea7e6d0cf2847c71812ddd31648ed31e7

comment:15 Changed 8 years ago by Alex Buts

refs #5955 Removed MDAlgorithms from VATES dependencies

Changeset: 093541c463b2779e9ff7626ee7d81ce7ccc01b93

comment:16 Changed 8 years ago by Alex Buts

refs #5955 Moved FameMDEventData

Changeset: 09cf8db7fec842b22e11f5331153020043a26d66

comment:17 Changed 8 years ago by Alex Buts

refs #5955 Fixing tests depending on the FakeMDEventsData

Changeset: 06dd4607affe9c33e36070bf9284f62fde4dec39

comment:18 Changed 8 years ago by Alex Buts

refs #5955 Moved CreateMDWorkspace and CreateMDHistoWorkspace

Changeset: 31a90376dcda7439ecba3539e0a480fc68a98fc1

comment:19 Changed 8 years ago by Alex Buts

refs #5955 Fixing build caused by move.

Changeset: 3a01fb796a6875c43ff2475605a005533dabb262

comment:20 Changed 8 years ago by Alex Buts

refs #5955 Moved IntegratePeaksMD and CentroidPeaksMD

Changeset: 90c300d8db394fc4fbda0281c9963ec0c6f44e42

comment:21 Changed 8 years ago by Alex Buts

refs #5955 Moved FindPeaksMD

Changeset: ce78ff149dee759ed7cd0b9089c2cd62e5edb7d1

comment:22 Changed 8 years ago by Alex Buts

  • Milestone changed from Release 2.4 to Release 2.5

comment:23 Changed 7 years ago by Alex Buts

  • Milestone changed from Release 2.5 to Release 2.6

comment:24 Changed 7 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to invalid

All MDAlgorithms initially present in MDEvents are moved to MDAlgorithms project.

Despite that during recent time people continue to add algorithms to MDEvents (e.g. SaveIsawQvector or ImportMDEventWorkspace) which makes the purpose of this ticket meaningless.

Last edited 7 years ago by Alex Buts (previous) (diff)

comment:25 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:26 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

Perhaps a review of all the algorithm folders is needed to ensure developers place new algorithms in the appropriate folder or can more easily find the algorithm they are looking for.

comment:27 Changed 7 years ago by Nick Draper

  • Component changed from VATES to Framework
  • Description modified (diff)

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6801

Note: See TracTickets for help on using tickets.