Ticket #5960 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

MaskWorkspaceToCalFile cannot accept a MaskedWorkspace!

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

A user recently reported this issue, which seems to be the result of MaskedWorkspaces, not having detectors tagged with the isMaskedFlag, even though they are masked! The obvious thing to do would be to fix the masking algorithm, but the problem is that there are still ongoing discussions about masking behaviour, and there is talk about having the isMasked flag return an integer indicating the degree of masking at a given point.

The fix should be as follows:

  • Determine whether the input workspace is a masking workspace.
  • If the input workspace is a masking workspace, use the 0, 1 values to determine the masking.
  • Otherwise use the isMasked flag.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #5960. More robust cal generation.

Can mask workspaces that are of type MaskingWorkspace. Updated to new python API. Unit test provided to cover new and existing functionality.

Changeset: 93424d9bf922998ffb27c1ba7456c62b2c22a9ca

comment:3 Changed 8 years ago by Owen Arnold

refs #5960. Add unit test.

Also remove demo test accidently put in last time round.

Changeset: 35fe220921e1534244845aea5648869c5fe90d41

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: The new unit test MaskWorkspaceToCalFileTest.py (which is now part of the test suite) might help establish how to test this new feature further. Note that the old functionality is already covered to some extent in the WishMasking.py system test script.

comment:5 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:6 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to verify
  • Tester Wenduo Zhou deleted

comment:7 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:8 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

files created from a matching maskWS and workspace2D are binary comparable.

comment:9 Changed 8 years ago by Owen Arnold

refs #5960. More robust cal generation.

Can mask workspaces that are of type MaskingWorkspace. Updated to new python API. Unit test provided to cover new and existing functionality.

Changeset: 93424d9bf922998ffb27c1ba7456c62b2c22a9ca

comment:10 Changed 8 years ago by Owen Arnold

refs #5960. Add unit test.

Also remove demo test accidently put in last time round.

Changeset: 35fe220921e1534244845aea5648869c5fe90d41

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6806

Note: See TracTickets for help on using tickets.