Ticket #5965 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Data doesn't stay the same after a SaveGSS/LoadGSS round trip

Reported by: Russell Taylor Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.3
Component: Framework Keywords: NewStarter
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

As far as I can see this is the case almost irrespective of the options chosen, though the differences are larger in some cases than in others.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:2 Changed 8 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

Some loss of metadata is unavoidable due to the limitations of the GSS format, but I beleive this ticket is refering to the counts themselves. This should be check and improved if possible.

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:4 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:9 Changed 6 years ago by Nick Draper

  • Keywords NewStarter added

comment:10 Changed 6 years ago by Nick Draper

  • Owner changed from Anyone to Raquel Alvarez Banos
  • Milestone changed from Backlog to Release 3.3

comment:11 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Save and Load GSS data Re #5965

Changeset: 2ef0ebafe18a42bf2934fc24cb57a00e303ada64

comment:12 Changed 6 years ago by Raquel Alvarez Banos

Save and Load GSS unit tests updated Re #5965

Changeset: 6f9bb02f5218c02e3a2a96941f762d00977cb179

comment:13 Changed 6 years ago by Raquel Alvarez Banos

Revert "Save and Load GSS unit tests updated Re #5965"

This reverts commit 6f9bb02f5218c02e3a2a96941f762d00977cb179.

Changeset: aec45e86fbf4630f564efc902963b1462291a147

comment:14 Changed 6 years ago by Raquel Alvarez Banos

Revert "Save and Load GSS data Re #5965"

This reverts commit 2ef0ebafe18a42bf2934fc24cb57a00e303ada64.

Changeset: 75c37e93ab4fbe7d1ffc7ac43df199b3d301d89b

comment:15 Changed 6 years ago by Raquel Alvarez Banos

Load and Save GSS Re #5965

Changeset: d01f6ae4c9a22fa4693b36251e7d1b70744b8f9b

comment:16 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

On the master branch, if you try the following steps:

Problem: SaveGSS writes (X,Y,E) values into a file. LoadGSS reads (X,Y,E) but applies the following conversion after reading:

          xValue = (2 * xValue) - xPrev;
          yValue = yValue / (xPrev * bc4);
          eValue = eValue / (xPrev * bc4);

LoadGSS algorithm has been modified so that (Y,E) stay the same after reading (for X the conversion is OK). In addition, the option "MultiplyByBinWidth" was not working for RALF format. It is added now.

To tester:

  • In this branch, follow the previous steps and check that the spectrum stays the same after the SaveGSS/LoadGSS round trip.

comment:17 Changed 6 years ago by Raquel Alvarez Banos

Load and Save GSS Doc updated Re #5965

Changeset: 5d738d6effc7544630e80e637fab6979316e3fb2

comment:18 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:19 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to closed

Merge branch 'bugfix/5965_save_and_load_GSS' of c:/Users/dsl37522/StagingMantid into bugfix/5965_save_and_load_GSS

Full changeset: 93d0920a7ba6f60f1d0dd4221abce80b39bbf8d5

comment:20 Changed 6 years ago by Dan Nixon

Merge remote-tracking branch 'origin/bugfix/5965_save_and_load_GSS'

Full changeset: 263a9ed6dee90c836aacfaab0305e561caaee6ab

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6811

Note: See TracTickets for help on using tickets.