Ticket #5975 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Quantification issues

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description

Russell Ewings has identified that the UB matrix is not correctly taken into account when performing a simulation. It appears to be ignored so that the Q space is not rotated as it should be.

There is also roughly a 10% difference in intensity.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

Quantification improvements. Refs #5975

For simulation the events are now constructed as you go which helps not having to remeber the order they were iterated over. Also tidied up YVector handling to allow attributes to be turned on/off separately.

Changeset: 3bd932a9e68214dd749d60394709ebe37a8371b2

comment:3 Changed 8 years ago by Martyn Gigg

Use include instead of forward declaration. Refs #5975

Fixes MSVC problem.

Changeset: 8b9324aa87db3c850f6eaac9323505cc6eda3a54

comment:4 Changed 8 years ago by Martyn Gigg

Remove static modifier to avoid possible threading issue. Refs #5975

Changeset: bf815f4c3920c6a23e3e3fa3247753fb09e1f311

comment:5 Changed 8 years ago by Martyn Gigg

Fix orientation issue within Strontrium model. Refs #5975

The U matrix was being multiplied in twice since ConvertToMD now does this, as it should.

Changeset: ca071a7e4b786ef2b9e951f3231a787e2da493f4

comment:6 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:8 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

the simulated image looks exactly like the sample image produced by Tobyfit for the same parameters.

comment:9 Changed 8 years ago by Martyn Gigg

Quantification improvements. Refs #5975

For simulation the events are now constructed as you go which helps not having to remeber the order they were iterated over. Also tidied up YVector handling to allow attributes to be turned on/off separately.

Changeset: 3bd932a9e68214dd749d60394709ebe37a8371b2

comment:10 Changed 8 years ago by Martyn Gigg

Use include instead of forward declaration. Refs #5975

Fixes MSVC problem.

Changeset: 8b9324aa87db3c850f6eaac9323505cc6eda3a54

comment:11 Changed 8 years ago by Martyn Gigg

Remove static modifier to avoid possible threading issue. Refs #5975

Changeset: bf815f4c3920c6a23e3e3fa3247753fb09e1f311

comment:12 Changed 8 years ago by Martyn Gigg

Fix orientation issue within Strontrium model. Refs #5975

The U matrix was being multiplied in twice since ConvertToMD now does this, as it should.

Changeset: ca071a7e4b786ef2b9e951f3231a787e2da493f4

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6821

Note: See TracTickets for help on using tickets.