Ticket #5978 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Additional debug outputs for FitParameters

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: minor Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description (last modified by Anders Markvardsen) (diff)

When FitParameters have been specified to provide initial guesses for parameters of fitting functions unit convert make take place.

Add some code which output debug information when such conversions take place.

Change History

comment:1 Changed 8 years ago by Anders Markvardsen

Addition debug output messages when unit convert i IFunction. re #5978

Changeset: a5529a83beff94491f519feeb567d1d80de7de5f

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:3 Changed 8 years ago by Anders Markvardsen

Addition debug output messages when unit convert i IFunction. re #5978

Changeset: a5529a83beff94491f519feeb567d1d80de7de5f

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:9 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to verify
  • Resolution set to fixed
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.3

Spotted this ticket has in fact been fixed 2 years ago. Code changes are already in master. Still worth verifying that code in master works.

To test:

  1. open e.g. any GEM data, e.g. GEM38370_Focussed_Legacy.nxs in AutoTestData
  1. to ensure that you have instrument fitting parameters loading, run LoadParameterFile with GEM_Parameters.xml from the instrument.
  1. change the logging to debug
  1. plot any spectrum and associate it with the fit function toolbox
  1. Add a IkedaCarpenterPV fit function

and you should see log information along the lines of: 

The FitParameter Alpha0 = 0.734079 before result-unit convertion (using 0.00128109)
The FitParameter Alpha0 = 0.000940421 after result-unit convertion
The FitParameter Alpha1 = 2.06725 before result-unit convertion (using 0.00128109)
The FitParameter Alpha1 = 0.00264833 after result-unit convertion
The FitParameter Beta0 = 32.0172 before result-unit convertion (using 0.00128109)
The FitParameter Beta0 = 0.0410169 after result-unit convertion
For FitParameter SigmaSquared centre of peak before any unit convertion is 35
For FitParameter SigmaSquared centre of peak after any unit convertion is 35
The FitParameter SigmaSquared = 204512 before result-unit convertion (using 0.00128109^2)
The FitParameter SigmaSquared = 0.335643 after result-unit convertion
For FitParameter Gamma centre of peak before any unit convertion is 35
For FitParameter Gamma centre of peak after any unit convertion is 35
The FitParameter Gamma = 9.695 before result-unit convertion (using 0.00128109)
The FitParameter Gamma = 0.0124202 after result-unit convertion

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6824

Note: See TracTickets for help on using tickets.