Ticket #5981 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

correct GSLFunctions::addNumberToColumn

Reported by: Jose Borreguero Owned by: Jose Borreguero
Priority: trivial Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

loop should be every 10 rows in the Jacobian matrix (iY+=10) instead of every row (iY++)

Change History

comment:1 Changed 8 years ago by Jose Borreguero

Refs #5981 Replace iY++ with iY+=10

modified: CurveFitting/inc/MantidCurveFitting/GSLFunctions.h

Changeset: 3e1c80e17cada2dc46c5ce70c1a2ac03addad8af

comment:2 Changed 8 years ago by Jose Borreguero

Refs #5981 Same changes for other Jacobian children

modified: GSLJacobian.h modified: Jacobian.h

Changeset: 5e4fe91d6b9ac9100c15321c1695e2b4ef5977fc

comment:3 Changed 8 years ago by Jose Borreguero

  • Status changed from new to accepted

comment:4 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:6 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to closed

It might be better to use a constant variable here. And make it to 10 with some explanation.

comment:7 Changed 8 years ago by Jose Borreguero

Refs #5981 Replace iY++ with iY+=10

modified: CurveFitting/inc/MantidCurveFitting/GSLFunctions.h

Changeset: 3e1c80e17cada2dc46c5ce70c1a2ac03addad8af

comment:8 Changed 8 years ago by Jose Borreguero

Refs #5981 Same changes for other Jacobian children

modified: GSLJacobian.h modified: Jacobian.h

Changeset: 5e4fe91d6b9ac9100c15321c1695e2b4ef5977fc

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6827

Note: See TracTickets for help on using tickets.