Ticket #5983 (closed: fixed)
Mantid crashes on attempt to show a simple instrument
Reported by: | Karl Palmen | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | |
Cc: | anders.markvardsen@… | Blocked By: | |
Blocking: | Tester: | Michael Reuter |
Change History
comment:2 Changed 8 years ago by Nick Draper
- Owner set to Roman Tolchenov
- Status changed from new to assigned
comment:4 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:8 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after the code freeze for R2.6
comment:9 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
bulk move to assigned at the into of the triage step
comment:10 Changed 6 years ago by Nick Draper
- Status changed from assigned to verify
- Owner changed from Roman Tolchenov to Nick Draper
- Resolution set to worksforme
- Description modified (diff)
tested with the file - no crash
comment:12 Changed 6 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:13 Changed 6 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution worksforme deleted
This still crashes on Windows (3.2.1 and master), OSX (3.2.1) and Fedora 20 (master). I'm reopening this. However, we need to question that the "minimal" IDF as no source or sample information is set. This is the cause for the crash. IMHO, this "minimal" IDF is incorrect as source and sample information (even fake ones) are an integral part of an instrument.
comment:14 Changed 6 years ago by Karl Palmen
If this is so, then we need an error message to the effect that no source or sample information is set, rather than a crash.
comment:15 Changed 6 years ago by Michael Reuter
Agreed. It should also remind the user that source and sample need to be set in the IDF.
comment:17 Changed 6 years ago by Roman Tolchenov
- Status changed from reopened to inprogress
Re #5983. Check if sample is null.
Changeset: 5bdc20b72545de7590b862a33355d8eb23c6b5d3
comment:18 Changed 6 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
comment:20 Changed 6 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
Two minor spelling mistakes need to be corrected. See the changeset for what to fix. Otherwise, this does what was requested.
comment:21 Changed 6 years ago by Roman Tolchenov
- Status changed from reopened to inprogress
Re #5983. Correct spelling mistakes.
Changeset: ae80e6bce6ba62471d05b5372c64c33965ec1664
comment:22 Changed 6 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
comment:24 Changed 6 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/5983_simple_instrument_crash'
Full changeset: 455ea7e97ecfe149a5fb2b18fb3b173feefc39a7
comment:25 Changed 6 years ago by Roman Tolchenov
Re #5983. Check if sample is null.
Changeset: 5bdc20b72545de7590b862a33355d8eb23c6b5d3
comment:25 Changed 6 years ago by Roman Tolchenov
Re #5983. Check if sample is null.
Changeset: 5bdc20b72545de7590b862a33355d8eb23c6b5d3
comment:27 Changed 6 years ago by Roman Tolchenov
Re #5983. Correct spelling mistakes.
Changeset: ae80e6bce6ba62471d05b5372c64c33965ec1664
comment:28 Changed 6 years ago by Roman Tolchenov
Re #5983. Correct spelling mistakes.
Changeset: ae80e6bce6ba62471d05b5372c64c33965ec1664
comment:29 Changed 6 years ago by Michael Reuter
Merge remote-tracking branch 'origin/bugfix/5983_simple_instrument_crash'
Full changeset: 455ea7e97ecfe149a5fb2b18fb3b173feefc39a7
comment:30 Changed 6 years ago by Michael Reuter
Merge remote-tracking branch 'origin/bugfix/5983_simple_instrument_crash'
Full changeset: 455ea7e97ecfe149a5fb2b18fb3b173feefc39a7
comment:31 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6829
Moved to milestone 2.4