Ticket #5990 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Reflectometry GUI

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: minor Milestone: Release 2.3
Component: Mantid Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Ship the Reflectometry GUI.

As this was developed outside of the Mantid development quality environment, we'll have to be careful about having it available by default if it is buggy.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Cc nick.draper@… added

comment:2 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to assigned
  • Owner changed from Owen Arnold to Gesner Passos

comment:4 Changed 8 years ago by Gesner Passos

  • Status changed from assigned to accepted

comment:5 Changed 8 years ago by Gesner Passos

As long we still do no have enough information/test case to ensure a minimum of quality of this GUI, we will not have it available by default right now. It will be possible to add this GUI through:

View->Manage Custom Menus->Add Script

Nevertheless, the files that are required to load the GUI will be inserted in the repository and will be available for this release.

comment:6 Changed 8 years ago by Gesner Passos

Adding necessary files for ISIS Reflectometry GUI

The following files are necessary in order to be able to add the Reflectometry GUI inside the Mantid->Interfaces menu.

Some issues:

  • reflgui.py was produced from a .ui file and than changed. It would be better to have the original .ui file.
    • There is still a note: WARNING! All changes made in this file will be lost!
  • reflgui.py was created as a MainWindow, in the new versions of Ubuntu, this will cause the main Mantid menu to be hidden.
  • The documentation of these files does not clearly identifies their function. Beside, new names to the function could be provided (for example l2q stands for?)
  • Some test demonstration should also be added if this GUI will be delivered as a Custom Mantid Interface.
  • It lacks a Wiki Page.

re #5990

Changeset: 490a57684cdaa2d4e88c79002264ffdc23d9ab94

comment:7 Changed 8 years ago by Martyn Gigg

Move ISIS reflectometry gui files to subdir. Refs #5990

Having them at top level meant that the directory no longer was added to the Python path, due to the presence of the init.py file. The OFFSPEC package then couldn't be located.

Changeset: 173cfdd2a828f95b4e8dfa214b70c35cd762ef56

comment:8 Changed 8 years ago by Russell Taylor

Re #5990. Fix line endings.

Changeset: 8b2b668784834a714650cedf5ba5d1b12e0fd6e3

comment:9 Changed 8 years ago by Gesner Passos

  • Owner changed from Gesner Passos to Owen Arnold
  • Status changed from accepted to assigned

It required updating the INTER_Definition.xml file in order to execute correctly. The good news is that it does succeed, at least, to the given user example. But, some work on this package should be done in order to become potentially useful for more users. TODO: we adapt the example to distribute this package. A minor issue during the execution, it tries to delete a workspace that it automatically plotted, so, this cause the user to be forced to decide many times, if he wants to hide, delete or cancel removing the workspace.

comment:10 Changed 8 years ago by Owen Arnold

  • Status changed from assigned to accepted

comment:11 Changed 8 years ago by Owen Arnold

refs #5990. Auto include reflectometry GUI.

Changeset: 402735155cbbd166c3765dadab6abe33be57115a

comment:12 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 8 years ago by Owen Arnold

  • Tester set to Nick Draper

comment:14 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester changed from Nick Draper to Anders Markvardsen

comment:15 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Tested that this new interface is accessible from MantidPlot and can stitch (merge) INTER data

comment:16 Changed 8 years ago by Gesner Passos

Adding necessary files for ISIS Reflectometry GUI

The following files are necessary in order to be able to add the Reflectometry GUI inside the Mantid->Interfaces menu.

Some issues:

  • reflgui.py was produced from a .ui file and than changed. It would be better to have the original .ui file.
    • There is still a note: WARNING! All changes made in this file will be lost!
  • reflgui.py was created as a MainWindow, in the new versions of Ubuntu, this will cause the main Mantid menu to be hidden.
  • The documentation of these files does not clearly identifies their function. Beside, new names to the function could be provided (for example l2q stands for?)
  • Some test demonstration should also be added if this GUI will be delivered as a Custom Mantid Interface.
  • It lacks a Wiki Page.

re #5990

Changeset: 490a57684cdaa2d4e88c79002264ffdc23d9ab94

comment:17 Changed 8 years ago by Martyn Gigg

Move ISIS reflectometry gui files to subdir. Refs #5990

Having them at top level meant that the directory no longer was added to the Python path, due to the presence of the init.py file. The OFFSPEC package then couldn't be located.

Changeset: 173cfdd2a828f95b4e8dfa214b70c35cd762ef56

comment:18 Changed 8 years ago by Russell Taylor

Re #5990. Fix line endings.

Changeset: 8b2b668784834a714650cedf5ba5d1b12e0fd6e3

comment:19 Changed 8 years ago by Owen Arnold

refs #5990. Auto include reflectometry GUI.

Changeset: 402735155cbbd166c3765dadab6abe33be57115a

comment:20 Changed 8 years ago by Owen Arnold

refs #5990. Auto include reflectometry GUI.

Changeset: 402735155cbbd166c3765dadab6abe33be57115a

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6836

Note: See TracTickets for help on using tickets.