Ticket #5993 (closed: worksforme)

Opened 8 years ago

Last modified 5 years ago

Memory not released when deleting event workspace

Reported by: Nick Draper Owned by: Russell Taylor
Priority: critical Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Seen on windows, may also occur elsewhere.

Steps to reproduce:

  1. Load an event workspace, I used an event nexus file from ISIS
  2. Delete the workspace
  3. Memory is not returned to the OS (as it is for a workspace 2D).
  4. Clear All memory does not work either
  5. The only way to get the memory back is to close Mantidplot

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Russell Taylor

Last edited 8 years ago by Russell Taylor (previous) (diff)

comment:3 Changed 8 years ago by Nick Draper

Feedback from Russell:

I haven’t been able to reproduce this consistently at all. Most notably, on Windows I have not once seen it not return the vast majority of the memory on deleting the workspace/clearing all memory. On linux & mac it feels like slightly odd things were happening at times, but that could just be the way these platforms report and reclaim memory. Using a release build and the Activity Monitor on rhel6 things look OK in MantidPlot. Valgrind on a unit test of loading LET00006278.nxs also seems happy. I was using version 2.2.975-g1268975 in all cases. If you still see this, perhaps you could say exactly what options you were using on the load.

Russell

comment:4 Changed 8 years ago by Nick Draper

I've tried this again this morning after Russells feedback, First I updated to the most recent development version of Mantid 2.2.977 and the short message is I cannot reproduce the bug any more.

I've tried small and large event files, various options for loading monitors and all of the seem to delete and release memory fine.

I'd worry that I was going mad if I hadn't got Owen to check he saw the same bug on his PC as well yesterday.

comment:5 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to worksforme

Closed as works for me, but needs retesting for the release version. Use both a smaller event file, but also a large one like LET something 500MB+ on disk.

comment:6 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

I loaded a very large event workspace generated by WISH ~15 GB in memory, and deleted it. task manager showed the recovery of the physical memory as the workspace was destroyed.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6839

Note: See TracTickets for help on using tickets.