Ticket #6023 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Relocate Python Algorithms and Include Updates

Reported by: Dereck Kachere Owned by: Dereck Kachere
Priority: blocker Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Move Force, IDAtransmission, iFudge, ILLines, JumpFit, Moments, MuscatData, MuscatFunc, QLines, Quest, ResNorm, Symmetrise from PythonAlgorithms directory to PythonAlgorithms/WorkflowAlgorithms.

Include updates (from Spencer) to IndirectCommon, IndirectDataAnalysis, IndirectAbsCor and IndirectForce.

Also delete Jump.

Change History

comment:1 Changed 8 years ago by Dereck Kachere

  • Owner set to Dereck Kachere
  • Status changed from new to accepted

comment:2 Changed 8 years ago by Dereck Kachere

refs #6023 Moved a few files around and updated.

Details as in ticket - deleted Jump, added newer versions of files and moved the the directories of some files.

Changeset: 3837fa2063f0bb184504eed091c8dab93e082ed6

comment:3 Changed 8 years ago by Martyn Gigg

Update system test as a result of script changes. Refs #6023

Changeset: c877d17a66b3d5b438a2c37e9c89794f7d6ac7df

comment:4 Changed 8 years ago by Martyn Gigg

Update reference result to include new error calculations. Refs #6023

The data values remain the same.

Changeset: 78d4e3cf09476e99c0ea740ae95a8a9d8a8e1066

comment:5 Changed 8 years ago by Martyn Gigg

Correct compuation of filename in Inelastic script. Refs #6023

Fixes system tests.

Changeset: 0917f7a27d3d8cb686925b6455bbd52ed58507f0

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

moved to Release 2.4

comment:7 Changed 8 years ago by Dereck Kachere

refs #5919 Reverted changes made by adding a file not fully up to date

Code which Spencer updated did not have the change I had originally made.

refs #6023 as well. Changed code so that when LoadNexus is run, the file's absolute path does not need to be entered.

Changeset: d0598be25c3ad0da19a58048189f9a909b90c5c5

comment:8 Changed 8 years ago by Dereck Kachere

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper
  • Milestone changed from Release 2.4 to Release 2.3

comment:10 Changed 8 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Nick Draper deleted

comment:11 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 8 years ago by Martyn Gigg

  • Priority changed from trivial to blocker
  • Status changed from verifying to reopened
  • Resolution fixed deleted

It looks like the algorithms that were supposed to be moved wer actually copied. The installer now has algorithms in both PythonAlgorithms & PythonAlgorithms/WorkflowAlgorithms.

The incorrect ones need removing before we release as it won't be clear to a user which ones are actually used.

On the bright side the system tests pass indicating that the other changes are okay so once the old files are removed the ticket can be passed.

comment:13 Changed 8 years ago by Dereck Kachere

  • Status changed from reopened to accepted

comment:14 Changed 8 years ago by Dereck Kachere

  • Status changed from accepted to verify
  • Resolution set to fixed

Referenced the incorrect ticket. Refer to #5573, comment 18.

comment:15 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Andrei Savici

comment:16 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

The pyc files are still there

comment:17 Changed 8 years ago by Dereck Kachere

refs #6023 Moved a few files around and updated.

Details as in ticket - deleted Jump, added newer versions of files and moved the the directories of some files.

Changeset: 3837fa2063f0bb184504eed091c8dab93e082ed6

comment:18 Changed 8 years ago by Martyn Gigg

Correct compuation of filename in Inelastic script. Refs #6023

Fixes system tests.

Changeset: 0917f7a27d3d8cb686925b6455bbd52ed58507f0

comment:19 Changed 8 years ago by Dereck Kachere

refs #5919 Reverted changes made by adding a file not fully up to date

Code which Spencer updated did not have the change I had originally made.

refs #6023 as well. Changed code so that when LoadNexus is run, the file's absolute path does not need to be entered.

Changeset: d0598be25c3ad0da19a58048189f9a909b90c5c5

comment:20 Changed 8 years ago by Dereck Kachere

refs #5919 Reverted changes made by adding a file not fully up to date

Code which Spencer updated did not have the change I had originally made.

refs #6023 as well. Changed code so that when LoadNexus is run, the file's absolute path does not need to be entered.

Changeset: d0598be25c3ad0da19a58048189f9a909b90c5c5

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6869

Note: See TracTickets for help on using tickets.