Ticket #6025 (closed: fixed)
Fix Smooth Neighbours
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Wenduo Zhou |
Description
SmoothNeighbours will crash if you do not specify the Radius, or set it to zero on an instrument such as WISH.
Write tests to cover these various scenarios. These should fail against the current implementation.
Set-up a better way to determine whether the algorithm should assume that the instrument uses rectangular detectors. Fix the tests as a result.
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #6025. Fix SmoothNeighbours.
Changeset: ab8711aa82f879f22866fc3dbe53a7cb055cdf2b
comment:3 Changed 8 years ago by Owen Arnold
refs #6025. Fix warning
Changeset: c3026bead0f8182380c6741571674a26af4f2483
comment:4 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:5 Changed 8 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:6 Changed 8 years ago by Owen Arnold
refs #6025. Break out of loop at earliest opportunity
Changeset: 96863005a0ebf8511719cc09bba23ae9ff0b0d88
comment:8 Changed 8 years ago by Owen Arnold
refs #6025. Fix SmoothNeighbours.
Changeset: ab8711aa82f879f22866fc3dbe53a7cb055cdf2b
comment:9 Changed 8 years ago by Owen Arnold
refs #6025. Fix warning
Changeset: c3026bead0f8182380c6741571674a26af4f2483
comment:10 Changed 8 years ago by Owen Arnold
refs #6025. Break out of loop at earliest opportunity
Changeset: 96863005a0ebf8511719cc09bba23ae9ff0b0d88
comment:11 Changed 8 years ago by Owen Arnold
refs #6025. Break out of loop at earliest opportunity
Changeset: 96863005a0ebf8511719cc09bba23ae9ff0b0d88
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6871
