Ticket #6031 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

CentroidPeaks on WISH

Reported by: Owen Arnold Owned by: Vickie Lynch
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

This is a complaint from Pascal on Wish to the effect that, the MatrixWorkspace version of this algorithm can't cope with Wish's 1:4 spectra to detector mapping.

Attachments

WISHCentroid.png (217.5 KB) - added by Vickie Lynch 8 years ago.

Change History

comment:1 Changed 8 years ago by Vickie Lynch

Refs #6031 flag for multiple detectors for workspace index

Changeset: 1d9dca435194af286a958484d13dc648dd7161dd

comment:2 Changed 8 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Russell Taylor

Re #6031. A bit of tidying up after fixing cppcheck for this class.

Changeset: e5083416c46ad9ca6616f632e53f206f89e5a88e

comment:4 Changed 8 years ago by Vickie Lynch

Refs #6031 number pixels for WISH IDF

Changeset: e7ab5f4c54486ceefb167a880ff5fb4c40732aa0

comment:5 Changed 8 years ago by Vickie Lynch

Refs #6031 find center with IntegratePeaksTimeSlices

Changeset: 0ea69b3912286d9cc4013da250649866244f1fe8

comment:6 Changed 8 years ago by Vickie Lynch

Refs #6031 flag for multiple detectors for workspace index

Changeset: 1d9dca435194af286a958484d13dc648dd7161dd

comment:7 Changed 8 years ago by Russell Taylor

Re #6031. A bit of tidying up after fixing cppcheck for this class.

Changeset: e5083416c46ad9ca6616f632e53f206f89e5a88e

comment:8 Changed 8 years ago by Vickie Lynch

Refs #6031 number pixels for WISH IDF

Changeset: e7ab5f4c54486ceefb167a880ff5fb4c40732aa0

comment:9 Changed 8 years ago by Vickie Lynch

Refs #6031 find center with IntegratePeaksTimeSlices

Changeset: 0ea69b3912286d9cc4013da250649866244f1fe8

comment:10 Changed 8 years ago by Vickie Lynch

Refs #6031 unused variable causes error with WISH data

Changeset: a12462fe4d84dd57e6aa1aba5f9c887fce0e500d

comment:11 Changed 8 years ago by Vickie Lynch

Refs #6031 find pixels by name from tubes

Changeset: ee4778c9949d8f4a3764060533ff8283546761a3

comment:12 Changed 8 years ago by Vickie Lynch

Refs #6031 unused variable causes error with WISH data

Changeset: ac006830310efba172f62fb8ab82167c99a7c705

comment:13 Changed 8 years ago by Vickie Lynch

Refs #6031 find pixels by name from tubes

Changeset: 6a20f82a278fd69fef960b99e59bc43f7faa523a

comment:14 Changed 8 years ago by Vickie Lynch

Refs #6031 better centroiding for histograms

Changeset: 887d01198fb16baf30b31860a59dc30b5b527d65

comment:15 Changed 8 years ago by Vickie Lynch

Refs #6031 fix edge check for WISH

Changeset: 3fb7fc74aa57007c6f1fb7e7ef8413260738be8d

Changed 8 years ago by Vickie Lynch

comment:16 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

To test, load WISH data, use Pick tool in show instrument to add a few single crystal peaks to a SingleCrystalPeakTable, and then run CentroidPeaks on that table. In attached plot, red marks original peak center and green marks centroided peak.

comment:17 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:18 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to verify
  • Tester Gesner Passos deleted

comment:19 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:20 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Played a bit with a WISH data set and the algorithm seems to give correct updated peak positions.

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6877

Note: See TracTickets for help on using tickets.