Ticket #6070 (assigned)

Opened 8 years ago

Last modified 5 years ago

SANS: Avoid warning messages from non assigned detectors

Reported by: Gesner Passos Owned by: Peter Parker
Priority: major Milestone: Backlog
Component: SANS Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester:

Description (last modified by Gesner Passos) (diff)

Running a Reduce1D for the front detector of LOQ or even SANS2D, you will end up with the following warning message:

Workspace index 698 (SpectrumIndex = 17085) has no detector assigned to it - discarding

The same message will be given for the following range of spectrum indexes: 16735:16736, 17085:17086, 17435:17436, 17785:17792.

By the definition of the HAB detector inside the LOQ_Definition_2012101-.xml file:

  <idlist idname="HAB">
    <id start="16387" end="16734" />
    <id start="17087" end="17434" />    
    <id start="16737" end="17084" />
    <id start="17437" end="17784" />
  </idlist>  

It follows that the spectrum indexes are not inside the HAB detector. In fact, according to the user, those spectrums are related to detectors spares or not in use.

So, although the algorithm (Q1D) correctly warns the user that those spectrums are not assigned, it would be better not to pass to this algorithm those spectrums, so to avoid the warning message.

Maybe the workspace should be cropped in order not to pass by these invalid spectrums.

To reproduce this:

Open SANS interface, set the instrument to LOQ, load the user file attached [user_file.txt], set to batch mode and load the [for-test.csv] and run 1D Reduce.

Attachments

for-test.csv (189 bytes) - added by Gesner Passos 8 years ago.
CSV File for testing in batch mode
user_file.txt (1.2 KB) - added by Gesner Passos 7 years ago.
User File
6070.patch (2.6 KB) - added by Gesner Passos 7 years ago.

Change History

Changed 8 years ago by Gesner Passos

CSV File for testing in batch mode

comment:1 Changed 8 years ago by Gesner Passos

  • Owner set to Gesner Passos
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:5 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:7 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to SANS
  • Description modified (diff)

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:9 Changed 7 years ago by Gesner Passos

To test, move the user_file.txt to the systemtest/Data/LOQ. And load it from there. The cycle is 12_3.

Changed 7 years ago by Gesner Passos

User File

comment:10 Changed 7 years ago by Gesner Passos

These spectra are in the middle of the HAB detector. And Q1D uses the for loop:

for i in number of spectra: 
  get detector

It will be impossible to crop those spectra from the workspace that is given to Q1D. I think the best option here would be to add a parameter inside the LOQ instrument to

Have a hardcoded number of spectra that should be ignored. Or a parameter inside the IDF to tell to ignore some detectors not assigned.

Changed 7 years ago by Gesner Passos

comment:11 Changed 7 years ago by Gesner Passos

  • Milestone changed from Backlog to Release 3.2

The file 6070.patch implements the option to add to idf a new parameter to ignore some spectra.

comment:12 Changed 7 years ago by Gesner Passos

  • Owner changed from Gesner Passos to Peter Parker

comment:13 Changed 6 years ago by Peter Parker

  • Milestone changed from Release 3.2 to Backlog

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6916

Note: See TracTickets for help on using tickets.