Ticket #6087 (closed: fixed)
Improve description and Unit test coverage for LeBailFit methods
| Reported by: | Alex Buts | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Vickie Lynch |
Description
There are number of methods in LaBailFit program, which do different things.
1) The comments say what the functions to but do not describe input-output parameters. This should be improved.
2) Unit tests for LeBailFit deal with the whole algorithm but do not cover each function separately. And some of them are pretty complex. I know, this is tedious task, but unit tests should verify these methods one by one or at least test most complex of them.
Change History
comment:2 Changed 8 years ago by Wenduo Zhou
More unit tests. Refs #6087 and #6019.
Changeset: 31e358795c7b5ff6a778c9a1e638a2b7302d9407
comment:3 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: 40c1d4619a17b3c26800f605e52223ef0372e504
comment:4 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: f798da8e18c06bc3f19b328b4bc5b845ef65f622
comment:5 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: 14b2c92351021b7cceb9c3606739ff9fdef366b8
comment:6 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: 05d8c022208b2344810a1706cb5976c5b636b09f
comment:7 Changed 8 years ago by Wenduo Zhou
More unit tests. Refs #6087 and #6019.
Changeset: b03bd6eacff713b33162bb46fd52d828e1d564e0
comment:8 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: 616fea753f4b6b74ecb46847ff4637e2e0fd22f2
comment:9 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: cf69ad9721930ef0067962a92af7c3046546ad4b
comment:10 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: 47e63296a46b7a701fa45ab5cb8a93426caf9a23
comment:11 Changed 8 years ago by Wenduo Zhou
Fix uni tests. Refs #6087 and #6019.
Changeset: 17b2da43bc32b7fd4492a910208c32422d62eab8
comment:12 Changed 8 years ago by Wenduo Zhou
Improve unit test. Refs #6087.
Changeset: c12c01667e91cb86238cdaecb40fd4fccdfafb80
comment:13 Changed 8 years ago by Wenduo Zhou
Improve unit test. Refs #6087.
Changeset: c12c01667e91cb86238cdaecb40fd4fccdfafb80
comment:14 Changed 8 years ago by Wenduo Zhou
Fix an error for windows build. Refs #6087.
Changeset: 7ff84be74d5011b8ee2a9a92672a955bc1e82b77
comment:15 Changed 8 years ago by Wenduo Zhou
Fix an error for windows build. Refs #6087.
Changeset: 7ff84be74d5011b8ee2a9a92672a955bc1e82b77
comment:16 Changed 8 years ago by Wenduo Zhou
Disable 1 test to make win32 work. Refs #6087.
Changeset: 762c00e2a301a4721be29456726157781b3f47a2
comment:17 Changed 8 years ago by Wenduo Zhou
Improve unit test. Refs #6087.
Changeset: 3c4defd9939c3802d96387090b4f82d4d8059138
comment:18 Changed 8 years ago by Wenduo Zhou
Fix an error for windows build. Refs #6087.
Changeset: 8d76e6062866817908552b7a4703276212fdd292
comment:19 Changed 8 years ago by Wenduo Zhou
Disable 1 test to make win32 work. Refs #6087.
Changeset: c2a59c5a10a4a5643804501ccc310ee413bc14f4
comment:20 Changed 8 years ago by Wenduo Zhou
Add more doc and comments to LeBailFit2. Refs #6087.
Changeset: 2142a9b61159597373c255ca95f9c765887ddd03
comment:21 Changed 8 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to fixed
comment:22 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:23 Changed 8 years ago by Vickie Lynch
Testing works correctly and very much documentation on the wiki
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6933
