Ticket #6122 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Crash when reloading Python Algorithm

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.3.1
Component: Python Keywords: PatchCandidate,Released
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

The bug from the previous release appear to be back, at least most of the time (somethimes it works).

  1. Load MaskWorkspacetocalfile.py into the script editor.
  2. execute it
  3. 3/4 times on windows 7 it crashes

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Keywords PatchCandidate added
  • Milestone changed from Release 2.4 to Release 2.3.1

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Martyn Gigg

Fix crash with PythonAlgorithm registration on windows. Refs #6122

There were several issues. First, there were two signal updates happening at the same time: one from MantidUI and another from AlgorithmSelectorWidget. Secondly, the AlgorithmSelectorWidget was receiving a Poco::Notification from a separate thread and not dispatching it to the GUI thread but instead calling update directly.

Changeset: bdc7ae82e72e51b9ac6b3e580dc4ffbb37f9c6a8

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Martyn Gigg

Fix crash with PythonAlgorithm registration on windows. Refs #6122

There were several issues. First, there were two signal updates happening at the same time: one from MantidUI and another from AlgorithmSelectorWidget. Secondly, the AlgorithmSelectorWidget was receiving a Poco::Notification from a separate thread and not dispatching it to the GUI thread but instead calling update directly.

Changeset: 6ed9b2f78e5defa7ab5b60910d802f0744bd74c1

comment:6 Changed 8 years ago by Peter Peterson

This was merged into the release branch.

comment:7 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:8 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

This was done correctly.

comment:9 Changed 8 years ago by Martyn Gigg

Fix crash with PythonAlgorithm registration on windows. Refs #6122

There were several issues. First, there were two signal updates happening at the same time: one from MantidUI and another from AlgorithmSelectorWidget. Secondly, the AlgorithmSelectorWidget was receiving a Poco::Notification from a separate thread and not dispatching it to the GUI thread but instead calling update directly.

Changeset: bdc7ae82e72e51b9ac6b3e580dc4ffbb37f9c6a8

comment:10 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6968

Note: See TracTickets for help on using tickets.