Ticket #6124 (closed: fixed)
MaskWorkspacetoCalFile does not handle grouping
Reported by: | Nick Draper | Owned by: | Nick Draper |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.3.1 |
Component: | Mantid | Keywords: | PatchCandidate,Released |
Cc: | owen.arnold@… | Blocked By: | |
Blocking: | Tester: | Owen Arnold |
Description
There also seem to be a 4-to-1 mapping issue on the MaskWorkspaceToCalFile, the old created cal files had 4 times more lines than the new ones. Could this be looked at asap, please? We have been trying to get this going from a remote computer for a week. The user is a Mantid skeptic and what he is seeing at the moment (even if some of the issues are not 100% Mantid problem) is proving him right.
Change History
comment:4 Changed 8 years ago by Nick Draper
re #6124 test for group was not working, brute force applied
Changeset: 4654d2acda44d4862fec04aba977100472c5f014
comment:5 Changed 8 years ago by Nick Draper
- Keywords PatchCandidate added
- Status changed from accepted to verify
- Resolution set to fixed
- Milestone changed from Release 2.4 to Release 2.3.1
comment:6 Changed 8 years ago by Nick Draper
re #6124 test for group was not working, brute force applied
Changeset: 24505ae0ca0060febb2b0c7640ce313c72ebc8e0
comment:8 Changed 8 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:9 Changed 8 years ago by Owen Arnold
Tested on various workspaces with different groupings. After masking and writing to cal files, the cal files look like I would expect them to given the cardinality of the mappings.
There should definitely be a regression test for this case #6204
comment:11 Changed 8 years ago by Nick Draper
re #6124 test for group was not working, brute force applied
Changeset: 4654d2acda44d4862fec04aba977100472c5f014
comment:12 Changed 7 years ago by Nick Draper
- Keywords PatchCandidate,Released added; PatchCandidate removed
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6970
For some reason the test type(det) = DetectorGroup is not working anymore.
Replaced it with a more brute force attempt to call the getDetectorIDs() method, and just catch the exception if it is not present.