Ticket #6151 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Migrate HFIR SANS reduction to workflow algorithms

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Migrate the HFIR SANS reduction to workflow algorithms. Any python written for this work should use the v2 API.

Change History

comment:1 Changed 8 years ago by Mathieu Doucet

Re #6151 Small API changes to prepare for v2 migration

Changeset: e61b01905772aab740fff5cddc417b86791f9b25

comment:2 Changed 8 years ago by Mathieu Doucet

Re #6151 Add normalisation algo and stub for HFIR reduction

Changeset: 9713565db48f14dca90b7b4065ce53ad44ea9bbc

comment:3 Changed 8 years ago by Mathieu Doucet

Re #6151 Ensure backward compatibility

Changeset: a5daeafb1db399b6badf91f4570edc929a53ccd3

comment:4 Changed 8 years ago by Mathieu Doucet

Re #6151 Add azimuthal averaging algo

Changeset: 7cb84d934fc56254f0502d078471ea0916c87efe

comment:5 Changed 8 years ago by Mathieu Doucet

Re #6151 Move HFIR normalisation to c++

Changeset: 00ec0a01a0a06e645af3903d8151c81dc832ddf5

comment:6 Changed 8 years ago by Mathieu Doucet

Re #6151 Add lightweight API v2 reducer code

Changeset: 65132ad47ef1d631bc7da187fffc05802bb6f759

comment:7 Changed 8 years ago by Mathieu Doucet

Re #6151 Add system test for API v2 reduction

Changeset: b41f73c81f12782b9a17e2a1f508111dcfaf4e66

comment:8 Changed 8 years ago by Mathieu Doucet

Re #6151 add background to API2 workflow

Changeset: 775184f2cde22ea8de254795765c8fa74aa52a25

comment:9 Changed 8 years ago by Mathieu Doucet

Re #6151 added background transmission

Changeset: 0502e290ee93f83be6185c10695baf770f8ccf27

comment:10 Changed 8 years ago by Mathieu Doucet

Re #6151 Add system tests for HFIR API2

Changeset: d54d3368ae7aa0f818f6115f278f23cc6b95539c

comment:11 Changed 8 years ago by Mathieu Doucet

Re #6151 Add system tests for HFIR API2

Changeset: 379d07a5cd42b44cc0a2a12c3063affe46e627fb

comment:12 Changed 8 years ago by Mathieu Doucet

Re #6151 complete EQSANS system test

Changeset: f764db917d7c466ca8ad4cc4f91959beaa30f973

comment:13 Changed 8 years ago by Mathieu Doucet

Re #6151 Move NormaliseByThickness to API2

Changeset: 176e55fc1da5ec55d8d348774f18aa0890ed7734

comment:14 Changed 8 years ago by Mathieu Doucet

Re #6151 added beam center option for sensitivity

Changeset: 30db5f8f6402503c3b7a19fbe4bc6c548016beb2

comment:15 Changed 8 years ago by Mathieu Doucet

Re #6151 added scattering beam center option for sensitivity

Changeset: c6ea811f3a8b9f12bc9e95d6ce1c08189c4aadef

comment:16 Changed 8 years ago by Mathieu Doucet

Re #6151 update system tests

Changeset: f2a7ec67f4524a8a71441e423fcc441bb2c43318

comment:17 Changed 8 years ago by Mathieu Doucet

Re #6151 Add reference results

Changeset: 9b0f1d4f40d435888b741b2031dd6c2ab860edd6

comment:18 Changed 8 years ago by Mathieu Doucet

Re #6151 Small API changes to prepare for v2 migration

Changeset: e61b01905772aab740fff5cddc417b86791f9b25

comment:19 Changed 8 years ago by Mathieu Doucet

Re #6151 Add normalisation algo and stub for HFIR reduction

Changeset: 9713565db48f14dca90b7b4065ce53ad44ea9bbc

comment:20 Changed 8 years ago by Mathieu Doucet

Re #6151 Ensure backward compatibility

Changeset: a5daeafb1db399b6badf91f4570edc929a53ccd3

comment:21 Changed 8 years ago by Mathieu Doucet

Re #6151 Add azimuthal averaging algo

Changeset: 7cb84d934fc56254f0502d078471ea0916c87efe

comment:22 Changed 8 years ago by Mathieu Doucet

Re #6151 Move HFIR normalisation to c++

Changeset: 00ec0a01a0a06e645af3903d8151c81dc832ddf5

comment:23 Changed 8 years ago by Mathieu Doucet

Re #6151 Add lightweight API v2 reducer code

Changeset: 65132ad47ef1d631bc7da187fffc05802bb6f759

comment:24 Changed 8 years ago by Mathieu Doucet

Re #6151 add background to API2 workflow

Changeset: 775184f2cde22ea8de254795765c8fa74aa52a25

comment:25 Changed 8 years ago by Mathieu Doucet

Re #6151 added background transmission

Changeset: 0502e290ee93f83be6185c10695baf770f8ccf27

comment:26 Changed 8 years ago by Mathieu Doucet

Re #6151 add beam spreader trans for HFIR API2

Changeset: 319e40d322779da3a5b0ec412b623e3a99855088

comment:27 Changed 8 years ago by Mathieu Doucet

Re #6151 Move NormaliseByThickness to API2

Changeset: 176e55fc1da5ec55d8d348774f18aa0890ed7734

comment:28 Changed 8 years ago by Mathieu Doucet

Re #6151 added beam center option for sensitivity

Changeset: 30db5f8f6402503c3b7a19fbe4bc6c548016beb2

comment:29 Changed 8 years ago by Mathieu Doucet

Re #6151 added scattering beam center option for sensitivity

Changeset: c6ea811f3a8b9f12bc9e95d6ce1c08189c4aadef

comment:30 Changed 8 years ago by Mathieu Doucet

Re #6151 adding transmission options to APIv2 reduction

Changeset: 5d5fdf58e1703e4071e17654e4135671ba3da02b

comment:31 Changed 8 years ago by Mathieu Doucet

Re #6151 more system tests for APIv2 changes

Changeset: 1b5047bede1389c08807f864b01e9be16f5f5d6c

comment:32 Changed 8 years ago by Mathieu Doucet

Re #6151 Tiny fixes to API2 reduction

Changeset: 80b7fd5503319063cdf4a74bc6295e98b23ee5cf

comment:33 Changed 8 years ago by Mathieu Doucet

Re #6151 finished background alg transition to API2

Changeset: 64a40d524e8176b5668217f173d9901ca679928a

comment:34 Changed 8 years ago by Mathieu Doucet

Re #6151 system tests for background sub

Changeset: ad982cf192f0e17145e43fb6c63dd788dacabbf7

comment:35 Changed 8 years ago by Mathieu Doucet

Re #6151 allow for saving output with APIv2

Changeset: 5dd056de0edaaaf1197b9ad4ac9a491d65c45848

comment:36 Changed 8 years ago by Mathieu Doucet

Re #6151 Add masking and absolute scaling for APIv2

Changeset: 3859900d0e4e2af8a93ee2de8f2fee15c1589a06

comment:37 Changed 8 years ago by Mathieu Doucet

Re #6151 System tests for mask & scaling

Changeset: c91b25f80ec4819ecd07a0c589f65c9d1bf7f6a2

comment:38 Changed 8 years ago by Mathieu Doucet

Re #6151 Add I(qx,qy) to API2

Changeset: 90911e262b2c63b951e3338a12f937635db1e48c

comment:39 Changed 8 years ago by Mathieu Doucet

Re #6151 Move resolution algorithm to API2

Changeset: f221acb36734713513e8024f002ffc33f36705da

comment:40 Changed 8 years ago by Martyn Gigg

Update SANSWorkflow test following algorithm update. Refs #6151

The OutputWorkspace of ReactorSANSResolution is now no longer used, the correction is done to the input workspace.

Changeset: ed1063699657e56c6d6f159798dfcae63a00810f

comment:41 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix problem with always writing files

Changeset: 568b39aa7826105ff5997d7273e0f5dde80484e7

comment:42 Changed 8 years ago by Mathieu Doucet

Re #6151 Add transmission output to prop mng for UI update

Changeset: 0cc414e99cad84f40b6b7c6d9b86222394eb9b84

comment:43 Changed 8 years ago by Mathieu Doucet

Re #6151 starting to make UI compatible with APIv2

Changeset: f3e93d6f87431f497e780801b265b394c5de8d03

comment:44 Changed 8 years ago by Mathieu Doucet

Re #6151 Allow API2 to use HFIR data proxy

Changeset: 6d0ee6927430275f7893e1b114cf65f4f00f0b97

comment:45 Changed 8 years ago by Mathieu Doucet

Re #6151 Add sample transmission to APIv2 UI

Changeset: f5df029ffdfba19d4a5ce706cf5a5123e0583895

comment:46 Changed 8 years ago by Mathieu Doucet

Re #6151 update UI catalog for APIv2

Changeset: 4f26cd9b5166d7aa1b7d9a063886e96c480499ea

comment:47 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix system tests

Changeset: f83dcaf1c6ea44ea9d3c7f1e228a89df76e1ef01

comment:48 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix system tests - part 2

Changeset: 47057680a63ae091f1d229c6e4a6f2e8581a9686

comment:49 Changed 8 years ago by Mathieu Doucet

Re #6151 move UI components to API2

Changeset: cebb87e443168c42ba9b40b636f2ebc6dab10656

comment:50 Changed 8 years ago by Mathieu Doucet

Re #6151 More transition to API2

Changeset: 4851f74442b7144a86290d295f9ba3fe94db59bb

comment:51 Changed 8 years ago by Mathieu Doucet

Re #6151 Reduction UI framework now entirely free of old API

Changeset: 493e72263dddd6d1473b619b33e68c157e2050e1

comment:52 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix issue with output values

Changeset: 3b4f7f0439f66b126629abcd9cba7a55406b42c9

comment:53 Changed 8 years ago by Mathieu Doucet

Re #6151 backward compatibility tweak

Changeset: e5d111bdf265f7d32869b16f40e1256d83628b8f

comment:54 Changed 8 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:55 Changed 8 years ago by Mathieu Doucet

Re #6151 adding transmission options to APIv2 reduction

Changeset: 9d703d53ac53b0ba86806a0b099bc477bcb01696

comment:56 Changed 8 years ago by Mathieu Doucet

Re #6151 Tiny fixes to API2 reduction

Changeset: 7c58f4e48ee85fd8fa202f9fd3185423704bdb85

comment:57 Changed 8 years ago by Mathieu Doucet

Re #6151 finished background alg transition to API2

Changeset: 431bf2feed436a48f51f9c07b1cc8c8fd7000e11

comment:58 Changed 8 years ago by Mathieu Doucet

Re #6151 allow for saving output with APIv2

Changeset: daf3ad13c32c60480f743551e749b95f43ee225f

comment:59 Changed 8 years ago by Mathieu Doucet

Re #6151 Add masking and absolute scaling for APIv2

Changeset: f06f884bc04053dba3ad52677bb2f7c14e7a8b4b

comment:60 Changed 8 years ago by Mathieu Doucet

Re #6151 Add I(qx,qy) to API2

Changeset: fa67b85bef72bd09a93936edacc6c3138658cb8a

comment:61 Changed 8 years ago by Mathieu Doucet

Re #6151 Move resolution algorithm to API2

Changeset: 78bb43152b0196b38079a080e19f1fd628828781

comment:62 Changed 8 years ago by Martyn Gigg

Update SANSWorkflow test following algorithm update. Refs #6151

The OutputWorkspace of ReactorSANSResolution is now no longer used, the correction is done to the input workspace.

Changeset: 685621b0bdbfdd8177ce3f6cc6a01214a36ccbd1

comment:63 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix problem with always writing files

Changeset: c5e170111748c5e3e73a4d8f06df7a8568bc4bd5

comment:64 Changed 8 years ago by Mathieu Doucet

Re #6151 Add transmission output to prop mng for UI update

Changeset: c2711984a81ed03bc5df3a015868c75bd3b322a0

comment:65 Changed 8 years ago by Mathieu Doucet

Re #6151 starting to make UI compatible with APIv2

Changeset: bf431cdb0f195c8e26d71977178a3ad9073c841a

comment:66 Changed 8 years ago by Mathieu Doucet

Re #6151 Allow API2 to use HFIR data proxy

Changeset: 7078b01548806807454001d2aad65213ae15fc42

comment:67 Changed 8 years ago by Mathieu Doucet

Re #6151 Add sample transmission to APIv2 UI

Changeset: bd48d79526ca24dc38a3039b8d5a80145f4106f5

comment:68 Changed 8 years ago by Mathieu Doucet

Re #6151 update UI catalog for APIv2

Changeset: 62fd8a22d28c338e53344a34c5ce14d4bc63e830

comment:69 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix system tests

Changeset: 7a48faff350871790aa758b673c5c3210f12f1fe

comment:70 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix system tests - part 2

Changeset: 1780b1840ad8c962bbc3dbb1741402849fafbe06

comment:71 Changed 8 years ago by Mathieu Doucet

Re #6151 move UI components to API2

Changeset: 571be9b9d46354aa00037cba141a878c3a33deec

comment:72 Changed 8 years ago by Mathieu Doucet

Re #6151 More transition to API2

Changeset: d3d705a3b9db21ed70109fcf0642aa3c4ff4de19

comment:73 Changed 8 years ago by Mathieu Doucet

Re #6151 Reduction UI framework now entirely free of old API

Changeset: c6490b203b5acf9357cca1a5811947c0b1956fbc

comment:74 Changed 8 years ago by Mathieu Doucet

Re #6151 Fix issue with output values

Changeset: 23ae07d75d3661f7cdf88591783097ca74aec4d2

comment:75 Changed 8 years ago by Mathieu Doucet

Re #6151 backward compatibility tweak

Changeset: b8eb587975b03dc8ea96bddb3da5ef4f330fd994

comment:76 Changed 8 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: Start the ORNL reduction interface and select "Use Mantid Python API v2" from the Tools menu. Results should be the same as when using the API v1. Export to script to see the code being run.

comment:77 Changed 8 years ago by Stuart Campbell

I had a problem saving the script using export on Mountain Lion - it crashed Mantid. I presume that this is a similar problem to #6497

comment:78 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

Opened ticket #6511 to look at this.

comment:79 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

comment:80 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6997

Note: See TracTickets for help on using tickets.