Ticket #6159 (closed: fixed)
Instrument View Should Mask to Temp Workspace
| Reported by: | Owen Arnold | Owned by: | Roman Tolchenov |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | nick.draper@… | Blocked By: | |
| Blocking: | #6160 | Tester: | Martyn Gigg |
Description
At the moment the instrument view masking is performing masking to the original workspace. This is causing problems for users who want to perform multiple masking operations that are not compounded, or those who simply do not expect the original workspace to become masked.
The solution is to generate a temporary masking workspace (probably best hidden) onto which all masking operations made in the instrument view are made. For the time being, ONLY allow the 'Apply' button to write to the original workspace. NO OTHER OPERATIONS SHOULD WRITE MASKING TO THE ORIGINAL WORKSPACE. 'Clear All' should wipe the temporary masking workspace, and completely restore the original state. I'll be generating another ticket for re-formatting and re-wiring the controls.
Change History
comment:5 Changed 8 years ago by Roman Tolchenov
Re #6159. Added a helper mask workspace to InstrumentActor
Changeset: 82800bdb35001660c3e566ec8f2d4e00430406bd
comment:6 Changed 8 years ago by Roman Tolchenov
Re #6159. Missed an include
Changeset: b29c60848a42c8a64bb771ac2f2154ddcb455612
comment:7 Changed 8 years ago by Roman Tolchenov
Re #6159. Refactored MaskTab to use the mask workspace
Changeset: aa8478a66dcfece1e55ad8d3ba79b4f0488cc664
comment:8 Changed 8 years ago by Roman Tolchenov
- Status changed from accepted to verify
- Resolution set to fixed
comment:9 Changed 8 years ago by Roman Tolchenov
Re #6159. Added a helper mask workspace to InstrumentActor
Changeset: 82800bdb35001660c3e566ec8f2d4e00430406bd
comment:10 Changed 8 years ago by Roman Tolchenov
Re #6159. Missed an include
Changeset: b29c60848a42c8a64bb771ac2f2154ddcb455612
comment:11 Changed 8 years ago by Roman Tolchenov
Re #6159. Refactored MaskTab to use the mask workspace
Changeset: aa8478a66dcfece1e55ad8d3ba79b4f0488cc664
comment:12 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:13 Changed 8 years ago by Martyn Gigg
Looks fine. Original workspace is only touched when you hit apply.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7005
I've updated the status of this ticket to Blocker, since we really ought not to do another release with the instrument view working like this.