Ticket #6162 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Remove Peak via the InstrumentView

Reported by: Owen Arnold Owned by: Roman Tolchenov
Priority: blocker Milestone: Release 2.4
Component: Mantid Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Owen Arnold

Description

The InstrumentView has some nice functionality for overlaying a peaks workspace and viewing the peak positions on the instrument plot.

Pascal has been asking (for quite some time) that we allow users to remove a peak from the peaks workspace via the instrument view. Change made in the instrument view should be reflected in the peaks workspace.

We should probably enable a right-click menu for removing the selected peak. I strongly suggest enlisting Nick Drapers help in determining how this should work before any coding is done. This functionality should also be trialled by Pascal before the ticket is marked as complete.

Change History

comment:1 Changed 8 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Roman Tolchenov

Re #6162. Fixes the instrument image disapearing

Changeset: 50160e89172d9079fcff2369af656a73f02f4416

comment:3 Changed 8 years ago by Roman Tolchenov

Re #6162. Added a new tool button to Pick Tab

Changeset: 956a6a9220d77c56e79ed0c68b9dff048e1120bc

comment:4 Changed 8 years ago by Roman Tolchenov

Re #6162. Deleted reference to removed resource

Changeset: 2830dd04fa103dbca2f3bd7505b772e183764acd

comment:5 Changed 8 years ago by Roman Tolchenov

Revert "Re #6162. Deleted reference to removed resource"

This reverts commit 2830dd04fa103dbca2f3bd7505b772e183764acd.

Changeset: 0e844c954da8b3757fe68834407b79c94e2b57c2

comment:6 Changed 8 years ago by Roman Tolchenov

Revert "Re #6162. Added a new tool button to Pick Tab"

This reverts commit 956a6a9220d77c56e79ed0c68b9dff048e1120bc.

Changeset: 00244cf346cdaa315f3b503fc7f6791952b55931

comment:7 Changed 8 years ago by Roman Tolchenov

Re #6162. Returning the reverted code

Changeset: 96e7961e327199d84c58b93998dcb92e9b181296

comment:8 Changed 8 years ago by Roman Tolchenov

Re #6162. Trying to fix the build.

Changeset: 0fa33ef3220a3c58e06629ac98f13e1305736b5c

comment:9 Changed 8 years ago by Roman Tolchenov

Re #6162. Fixes the instrument image disapearing

Changeset: 50160e89172d9079fcff2369af656a73f02f4416

comment:10 Changed 8 years ago by Roman Tolchenov

Re #6162. Added a new tool button to Pick Tab

Changeset: 956a6a9220d77c56e79ed0c68b9dff048e1120bc

comment:11 Changed 8 years ago by Roman Tolchenov

Re #6162. Deleted reference to removed resource

Changeset: 2830dd04fa103dbca2f3bd7505b772e183764acd

comment:12 Changed 8 years ago by Roman Tolchenov

Revert "Re #6162. Deleted reference to removed resource"

This reverts commit 2830dd04fa103dbca2f3bd7505b772e183764acd.

Changeset: 0e844c954da8b3757fe68834407b79c94e2b57c2

comment:13 Changed 8 years ago by Roman Tolchenov

Revert "Re #6162. Added a new tool button to Pick Tab"

This reverts commit 956a6a9220d77c56e79ed0c68b9dff048e1120bc.

Changeset: 00244cf346cdaa315f3b503fc7f6791952b55931

comment:14 Changed 8 years ago by Roman Tolchenov

Re #6162. Returning the reverted code

Changeset: 96e7961e327199d84c58b93998dcb92e9b181296

comment:15 Changed 8 years ago by Roman Tolchenov

Re #6162. Trying to fix the build.

Changeset: 0fa33ef3220a3c58e06629ac98f13e1305736b5c

comment:16 Changed 8 years ago by Roman Tolchenov

Re #6162. Little refactoring

Changeset: 08f60dda33d033435626f9ed9578709457dca909

comment:17 Changed 8 years ago by Roman Tolchenov

Re #6162. Reconnected the instrument tree widget.

Changeset: defb7feb145f0c125d7977953f3490608b12cfc2

comment:18 Changed 8 years ago by Roman Tolchenov

Re #6162. Restored component selection in script

Changeset: c9eff45ca5d6e5922219ee24c9af51dcd4a3cbb6

comment:19 Changed 8 years ago by Roman Tolchenov

Re #6162. Wrapped projection surface in a shared pointer

Changeset: 580133e6fb828ec2fda7cb58caebec5d97fc344d

comment:20 Changed 8 years ago by Roman Tolchenov

Re #6162. Added an eraser icon.

Changeset: e71636470d363961675a0d91c716fb63636adac2

comment:21 Changed 8 years ago by Roman Tolchenov

Re #6162. Refactored user input in instrument view.

Changeset: d1e0ad74592dd278610e93117b7a7eabe34732fd

comment:22 Changed 8 years ago by Roman Tolchenov

Re #6162. Refactored 2d shapes

Changeset: 6df2da63df72097d83237a3af9aed10940c51c8c

comment:23 Changed 8 years ago by Roman Tolchenov

Re #6162. Added an eraser icon.

Changeset: 4e83fbaa36b9d5de55dd36172af0026dcc2a9ed7

comment:24 Changed 8 years ago by Roman Tolchenov

Re #6162. Refactored user input in instrument view.

Changeset: 8d2c5a5590322864be7c78f1f78ff24c7f80e7ca

comment:25 Changed 8 years ago by Roman Tolchenov

Re #6162. Refactored 2d shapes

Changeset: 45f3601f4e4adfe55056cd0d28adfc9110d5a9b5

comment:26 Changed 8 years ago by Roman Tolchenov

Re #6162. Sorted out the shapes transformations.

Changeset: e9551b544212988073af8cb16612e19cb1c124b0

comment:27 Changed 8 years ago by Roman Tolchenov

Re #6162. Corrected shape selection. Added image to cursor

Changeset: bb536500f3b601b58e311c81a82624a6c904084b

comment:28 Changed 8 years ago by Roman Tolchenov

Re #6162. Improvements to InstrumentView's infos

Changeset: d4a8d38e12ec7b0e41cfb77c3fff714e5e14ca88

comment:29 Changed 8 years ago by Roman Tolchenov

Re #6162. Added missing include.

Changeset: 93f02c7c7ae4eac66b823cbd498434d1ee102361

comment:30 Changed 8 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:31 Changed 8 years ago by Roman Tolchenov

Re #6162. Little refactoring

Changeset: f6227cb2f1369d033b09aeb243f73c61f8981517

comment:32 Changed 8 years ago by Roman Tolchenov

Re #6162. Reconnected the instrument tree widget.

Changeset: 8c8ce3856c8c83a5dbe6f7595a6660961787e141

comment:33 Changed 8 years ago by Roman Tolchenov

Re #6162. Restored component selection in script

Changeset: d3500b7d4203780d73ef4a16b62a45e28a8625d1

comment:34 Changed 8 years ago by Roman Tolchenov

Re #6162. Wrapped projection surface in a shared pointer

Changeset: 9799d6643e1ff6e0b66318278b2adce2d17ee3a5

comment:35 Changed 8 years ago by Roman Tolchenov

Re #6162. Added an eraser icon.

Changeset: 7f8672e4dd684f83d3725d37ca5336f642faa1ca

comment:36 Changed 8 years ago by Roman Tolchenov

Re #6162. Refactored user input in instrument view.

Changeset: 437adc716cdbbcccf2f95137adcca4ea5affa794

comment:37 Changed 8 years ago by Roman Tolchenov

Re #6162. Refactored 2d shapes

Changeset: eb193e4631284d9d3fe68e238f70d631b279cd8d

comment:38 Changed 8 years ago by Roman Tolchenov

Re #6162. Sorted out the shapes transformations.

Changeset: 0de02c5d3fc0d70a8e7409c482ce04ee5031d67b

comment:39 Changed 8 years ago by Roman Tolchenov

Re #6162. Corrected shape selection. Added image to cursor

Changeset: 12314775f5e029f5c5b2c64c401b0fde89458c92

comment:40 Changed 8 years ago by Roman Tolchenov

Re #6162. Improvements to InstrumentView's infos

Changeset: 082750cc3781f52ef1749c50a38a28715318d3b2

comment:41 Changed 8 years ago by Roman Tolchenov

Re #6162. Added missing include.

Changeset: 66f6d4f3e75c5539bf22e0b851b24e02a20a2424

comment:42 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:43 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

This seems to work as I would expect it to.

comment:44 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7008

Note: See TracTickets for help on using tickets.