Ticket #6171 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Bug in script history for Fit?

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description

At the developer meeting an atempt to get the script history failed for a fir algorithm. Check if there is a problem here.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:3 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:4 Changed 7 years ago by Roman Tolchenov

Set workspaceProperty's workspace name. Re #6171

Changeset: 71523b85c0a5856cfec94f29440504e239b8a2d7

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Fixing failng tests. Re #6171

Changeset: 37ceb335f688dfb9d9ea424c125470b1e0097d5e

comment:9 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.0

moved to Release 3.0 as these all seem to be active

comment:11 Changed 7 years ago by Roman Tolchenov

  • Milestone changed from Release 3.0 to Release 3.1

comment:12 Changed 7 years ago by Roman Tolchenov

Set workspaceProperty's workspace name. Re #6171

Changeset: 71523b85c0a5856cfec94f29440504e239b8a2d7

comment:13 Changed 7 years ago by Roman Tolchenov

Re #6171. Added unit tests for WorkspaceProperty.

Changeset: 80013d9620b55387518f50e0bb61dafe3f009772

comment:14 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

The problem was that the history doesn't record the name of an input workspace if it was passed to an algorithm as a shared pointer. This happened because WorkspaceProperty didn't store the workspace name.

comment:15 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:16 Changed 7 years ago by Alex Buts

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/6171_script_history'

Full changeset: ​939f0fd5679214e84152cbf0e43cd3071c5c7f54

comment:17 Changed 7 years ago by Alex Buts

Can not reproduce initial issue so passed after code review.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7017

Note: See TracTickets for help on using tickets.