Ticket #6177 (closed: fixed)
Script repository integration with Mantidplot
| Reported by: | Nick Draper | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | #6174, #6175 | |
| Blocking: | Tester: | Alex Buts |
Description
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:5 Changed 7 years ago by Gesner Passos
- Blocked By 6174 added
(In #6174) branch : feature/6174_script_repo_design
Tester: Read the documentation, specially the sections Script Repository GUI and Uploading Strategy. You should agree with this document, and them merge it to master. If you agree, this will be the implemented version of ScriptRepository. (The ScriptRepository Service has already been implemented in #6175).
Attention: the git macros will not work here. You will have to merge using the git commands:
git checkout master git fetch -p git pull --rebase git merge --no-ff origin/feature/6174_script_repo_design
If you agree with the document, publish it:
git fetch git rebase --preserve-merges origin/master git push origin master git push origin :feature/6174_script_repo_design
comment:7 Changed 7 years ago by Gesner Passos
Small changes to the ScriptRepository interface for improvement
Attempt to improve the interface for the sake of performance. Otherwise, plenty of copy of strings will be made that are useless.
re #6177
Changeset: 2c291ece8559905907f15f6f001a5cad3654f5fb
comment:8 Changed 7 years ago by Gesner Passos
Implementation of RepoModel
It fits the requirement of QAbstractItemModel
re #6177
Changeset: 2394e42563270044963240d5c30a7bb7bec5956c
comment:10 Changed 7 years ago by Gesner Passos
Add RepoTreeView class
Just header class, its intention is to make known that the current selection of has changed. This is usefull to display the correct metainformation of the entries.
re #6177
Changeset: 81a384f52b12564a7db467fef3c24f3258558e76
comment:11 Changed 7 years ago by Gesner Passos
Introduction of ScriptRepositoryView
The class responsible for the UserInterface of ScriptRepository
re #6177
Changeset: b811db12302c2b4eba9e5bb6a2008a830d99afa6
comment:12 Changed 7 years ago by Gesner Passos
Correct a bug introduced
The commit http://trac.mantidproject.org/mantid/changeset/2c291ece8559905907f15f6f001a5cad3654f5fb/ has introduced a bug, that does not update the status of a downloaded directory.
This solves the issue. re #6177
Changeset: b99ba46c255d3b50896bfcca957abe40bcc43115
comment:13 Changed 7 years ago by Gesner Passos
Remove useless code of ScriptRepositoryImpl
re #6177
Changeset: c225ed535b2aeda14edf99517bf9486de7525b00
comment:14 Changed 7 years ago by Gesner Passos
Add support for Upload from the User Interaction point of view
re #6177
Changeset: 84d6068fa2c6824ca2d6931d981a7445d89dbe08
comment:15 Changed 7 years ago by Gesner Passos
comment:16 Changed 7 years ago by Gesner Passos
Handle exceptions RepoModel
Allow the RepoModel to handle download/upload exceptions and inform the the reason.
re #6177
Changeset: aea75884d665f086f8784a4151aa506634be0236
comment:17 Changed 7 years ago by Gesner Passos
Improve the information of some exceptions
re #6177
Changeset: 9caff91cf930960ec7b0b50a465bc077284e8cf8
comment:18 Changed 7 years ago by Gesner Passos
comment:19 Changed 7 years ago by Gesner Passos
Does not create an empty file when download fails.
re #6177
Changeset: 3c0b70dce81079ef87256eabc92d39b953aaa5a0
comment:20 Changed 7 years ago by Gesner Passos
Correct the ScriptRepositoryTest to not change the properties
When the unittest is executed it should not change the configured user property. Add also a new unit test to ensure that folder has correct status after download.
re #6177
Changeset: fd11b9f79709eac454ec9a276d58cdd91b1384f0
comment:21 Changed 7 years ago by Gesner Passos
Correct the installation of ScriptRepository
It is possible to install the ScriptRepository at the same path of a previous installation.
re #6177
Changeset: df1bc890316d51ebbd48964daa8e06d9343666df
comment:22 Changed 7 years ago by Gesner Passos
Ensure model is correctly created to create widget
re #6177
Changeset: dd10a2cffe746465c9f18dd1f31e41834d36daa6
comment:23 Changed 7 years ago by Gesner Passos
comment:24 Changed 7 years ago by Gesner Passos
Tester:
you are encouraged to open the ScriptRepository : Menu->File->ScriptRepository.
Install it, download some files and folders, check if you like the interface, if it is 'friendly'. The upload part is already integrated with the ScriptRepository Service, but because this last one does not implement the uploading, you will not be able to upload files, but, you can judge the way it will allow you to upload.
the branch is feature/6177_script_repo_mantidplot
comment:25 Changed 7 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
comment:26 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:27 Changed 7 years ago by Nick Draper
- Status changed from verifying to verify
- Tester Nick Draper deleted
Darn, I can't get the VPN to connect from here. I'll have to pass this one back.
comment:28 Changed 7 years ago by Alex Buts
- Status changed from verify to verifying
- Tester set to Alex Buts
comment:29 Changed 7 years ago by Alex Buts
- Status changed from verifying to closed
Script repository is integrated with Mantid plot and looks good.
There are problems which should be addressed in separate tickets:
1)Bug: Auto update field does not work
2)Feature: First installation of the script repository looks like Mantid crash.
Can be very useful otherwise.
comment:30 Changed 7 years ago by Gesner Passos
Small changes to the ScriptRepository interface for improvement
Attempt to improve the interface for the sake of performance. Otherwise, plenty of copy of strings will be made that are useless.
re #6177
Changeset: 2c291ece8559905907f15f6f001a5cad3654f5fb
comment:31 Changed 7 years ago by Gesner Passos
Implementation of RepoModel
It fits the requirement of QAbstractItemModel
re #6177
Changeset: 2394e42563270044963240d5c30a7bb7bec5956c
comment:32 Changed 7 years ago by Gesner Passos
comment:33 Changed 7 years ago by Gesner Passos
Add RepoTreeView class
Just header class, its intention is to make known that the current selection of has changed. This is usefull to display the correct metainformation of the entries.
re #6177
Changeset: 81a384f52b12564a7db467fef3c24f3258558e76
comment:34 Changed 7 years ago by Gesner Passos
Introduction of ScriptRepositoryView
The class responsible for the UserInterface of ScriptRepository
re #6177
Changeset: b811db12302c2b4eba9e5bb6a2008a830d99afa6
comment:35 Changed 7 years ago by Gesner Passos
Correct a bug introduced
The commit http://trac.mantidproject.org/mantid/changeset/2c291ece8559905907f15f6f001a5cad3654f5fb/ has introduced a bug, that does not update the status of a downloaded directory.
This solves the issue. re #6177
Changeset: b99ba46c255d3b50896bfcca957abe40bcc43115
comment:36 Changed 7 years ago by Gesner Passos
Remove useless code of ScriptRepositoryImpl
re #6177
Changeset: c225ed535b2aeda14edf99517bf9486de7525b00
comment:37 Changed 7 years ago by Gesner Passos
Add support for Upload from the User Interaction point of view
re #6177
Changeset: 84d6068fa2c6824ca2d6931d981a7445d89dbe08
comment:38 Changed 7 years ago by Gesner Passos
comment:39 Changed 7 years ago by Gesner Passos
Handle exceptions RepoModel
Allow the RepoModel to handle download/upload exceptions and inform the the reason.
re #6177
Changeset: aea75884d665f086f8784a4151aa506634be0236
comment:40 Changed 7 years ago by Gesner Passos
Improve the information of some exceptions
re #6177
Changeset: 9caff91cf930960ec7b0b50a465bc077284e8cf8
comment:41 Changed 7 years ago by Gesner Passos
comment:42 Changed 7 years ago by Gesner Passos
Does not create an empty file when download fails.
re #6177
Changeset: 3c0b70dce81079ef87256eabc92d39b953aaa5a0
comment:43 Changed 7 years ago by Gesner Passos
Correct the ScriptRepositoryTest to not change the properties
When the unittest is executed it should not change the configured user property. Add also a new unit test to ensure that folder has correct status after download.
re #6177
Changeset: fd11b9f79709eac454ec9a276d58cdd91b1384f0
comment:44 Changed 7 years ago by Gesner Passos
Correct the installation of ScriptRepository
It is possible to install the ScriptRepository at the same path of a previous installation.
re #6177
Changeset: df1bc890316d51ebbd48964daa8e06d9343666df
comment:45 Changed 7 years ago by Gesner Passos
Ensure model is correctly created to create widget
re #6177
Changeset: dd10a2cffe746465c9f18dd1f31e41834d36daa6
comment:46 Changed 7 years ago by Gesner Passos
comment:47 Changed 7 years ago by Gesner Passos
Small changes to the ScriptRepository interface for improvement
Attempt to improve the interface for the sake of performance. Otherwise, plenty of copy of strings will be made that are useless.
re #6177
Changeset: 2c291ece8559905907f15f6f001a5cad3654f5fb
comment:48 Changed 7 years ago by Gesner Passos
Implementation of RepoModel
It fits the requirement of QAbstractItemModel
re #6177
Changeset: 2394e42563270044963240d5c30a7bb7bec5956c
comment:49 Changed 7 years ago by Gesner Passos
comment:50 Changed 7 years ago by Gesner Passos
Add RepoTreeView class
Just header class, its intention is to make known that the current selection of has changed. This is usefull to display the correct metainformation of the entries.
re #6177
Changeset: 81a384f52b12564a7db467fef3c24f3258558e76
comment:51 Changed 7 years ago by Gesner Passos
Introduction of ScriptRepositoryView
The class responsible for the UserInterface of ScriptRepository
re #6177
Changeset: b811db12302c2b4eba9e5bb6a2008a830d99afa6
comment:52 Changed 7 years ago by Gesner Passos
Correct a bug introduced
The commit http://trac.mantidproject.org/mantid/changeset/2c291ece8559905907f15f6f001a5cad3654f5fb/ has introduced a bug, that does not update the status of a downloaded directory.
This solves the issue. re #6177
Changeset: b99ba46c255d3b50896bfcca957abe40bcc43115
comment:53 Changed 7 years ago by Gesner Passos
Remove useless code of ScriptRepositoryImpl
re #6177
Changeset: c225ed535b2aeda14edf99517bf9486de7525b00
comment:54 Changed 7 years ago by Gesner Passos
Add support for Upload from the User Interaction point of view
re #6177
Changeset: 84d6068fa2c6824ca2d6931d981a7445d89dbe08
comment:55 Changed 7 years ago by Gesner Passos
comment:56 Changed 7 years ago by Gesner Passos
Handle exceptions RepoModel
Allow the RepoModel to handle download/upload exceptions and inform the the reason.
re #6177
Changeset: aea75884d665f086f8784a4151aa506634be0236
comment:57 Changed 7 years ago by Gesner Passos
Improve the information of some exceptions
re #6177
Changeset: 9caff91cf930960ec7b0b50a465bc077284e8cf8
comment:58 Changed 7 years ago by Gesner Passos
comment:59 Changed 7 years ago by Gesner Passos
Does not create an empty file when download fails.
re #6177
Changeset: 3c0b70dce81079ef87256eabc92d39b953aaa5a0
comment:60 Changed 7 years ago by Gesner Passos
Correct the ScriptRepositoryTest to not change the properties
When the unittest is executed it should not change the configured user property. Add also a new unit test to ensure that folder has correct status after download.
re #6177
Changeset: fd11b9f79709eac454ec9a276d58cdd91b1384f0
comment:61 Changed 7 years ago by Gesner Passos
Correct the installation of ScriptRepository
It is possible to install the ScriptRepository at the same path of a previous installation.
re #6177
Changeset: df1bc890316d51ebbd48964daa8e06d9343666df
comment:62 Changed 7 years ago by Gesner Passos
Ensure model is correctly created to create widget
re #6177
Changeset: dd10a2cffe746465c9f18dd1f31e41834d36daa6
comment:63 Changed 7 years ago by Gesner Passos
comment:64 Changed 7 years ago by Gesner Passos
Small changes to the ScriptRepository interface for improvement
Attempt to improve the interface for the sake of performance. Otherwise, plenty of copy of strings will be made that are useless.
re #6177
Changeset: 2c291ece8559905907f15f6f001a5cad3654f5fb
comment:65 Changed 7 years ago by Gesner Passos
Implementation of RepoModel
It fits the requirement of QAbstractItemModel
re #6177
Changeset: 2394e42563270044963240d5c30a7bb7bec5956c
comment:66 Changed 7 years ago by Gesner Passos
comment:67 Changed 7 years ago by Gesner Passos
Add RepoTreeView class
Just header class, its intention is to make known that the current selection of has changed. This is usefull to display the correct metainformation of the entries.
re #6177
Changeset: 81a384f52b12564a7db467fef3c24f3258558e76
comment:68 Changed 7 years ago by Gesner Passos
Introduction of ScriptRepositoryView
The class responsible for the UserInterface of ScriptRepository
re #6177
Changeset: b811db12302c2b4eba9e5bb6a2008a830d99afa6
comment:69 Changed 7 years ago by Gesner Passos
Correct a bug introduced
The commit http://trac.mantidproject.org/mantid/changeset/2c291ece8559905907f15f6f001a5cad3654f5fb/ has introduced a bug, that does not update the status of a downloaded directory.
This solves the issue. re #6177
Changeset: b99ba46c255d3b50896bfcca957abe40bcc43115
comment:70 Changed 7 years ago by Gesner Passos
Remove useless code of ScriptRepositoryImpl
re #6177
Changeset: c225ed535b2aeda14edf99517bf9486de7525b00
comment:71 Changed 7 years ago by Gesner Passos
Add support for Upload from the User Interaction point of view
re #6177
Changeset: 84d6068fa2c6824ca2d6931d981a7445d89dbe08
comment:72 Changed 7 years ago by Gesner Passos
comment:73 Changed 7 years ago by Gesner Passos
Handle exceptions RepoModel
Allow the RepoModel to handle download/upload exceptions and inform the the reason.
re #6177
Changeset: aea75884d665f086f8784a4151aa506634be0236
comment:74 Changed 7 years ago by Gesner Passos
Improve the information of some exceptions
re #6177
Changeset: 9caff91cf930960ec7b0b50a465bc077284e8cf8
comment:75 Changed 7 years ago by Gesner Passos
comment:76 Changed 7 years ago by Gesner Passos
Does not create an empty file when download fails.
re #6177
Changeset: 3c0b70dce81079ef87256eabc92d39b953aaa5a0
comment:77 Changed 7 years ago by Gesner Passos
Correct the ScriptRepositoryTest to not change the properties
When the unittest is executed it should not change the configured user property. Add also a new unit test to ensure that folder has correct status after download.
re #6177
Changeset: fd11b9f79709eac454ec9a276d58cdd91b1384f0
comment:78 Changed 7 years ago by Gesner Passos
Correct the installation of ScriptRepository
It is possible to install the ScriptRepository at the same path of a previous installation.
re #6177
Changeset: df1bc890316d51ebbd48964daa8e06d9343666df
comment:79 Changed 7 years ago by Gesner Passos
Ensure model is correctly created to create widget
re #6177
Changeset: dd10a2cffe746465c9f18dd1f31e41834d36daa6
comment:80 Changed 7 years ago by Gesner Passos
comment:81 Changed 7 years ago by Gesner Passos
Small changes to the ScriptRepository interface for improvement
Attempt to improve the interface for the sake of performance. Otherwise, plenty of copy of strings will be made that are useless.
re #6177
Changeset: 2c291ece8559905907f15f6f001a5cad3654f5fb
comment:82 Changed 7 years ago by Gesner Passos
Implementation of RepoModel
It fits the requirement of QAbstractItemModel
re #6177
Changeset: 2394e42563270044963240d5c30a7bb7bec5956c
comment:83 Changed 7 years ago by Gesner Passos
comment:84 Changed 7 years ago by Gesner Passos
Add RepoTreeView class
Just header class, its intention is to make known that the current selection of has changed. This is usefull to display the correct metainformation of the entries.
re #6177
Changeset: 81a384f52b12564a7db467fef3c24f3258558e76
comment:85 Changed 7 years ago by Gesner Passos
Introduction of ScriptRepositoryView
The class responsible for the UserInterface of ScriptRepository
re #6177
Changeset: b811db12302c2b4eba9e5bb6a2008a830d99afa6
comment:86 Changed 7 years ago by Gesner Passos
Correct a bug introduced
The commit http://trac.mantidproject.org/mantid/changeset/2c291ece8559905907f15f6f001a5cad3654f5fb/ has introduced a bug, that does not update the status of a downloaded directory.
This solves the issue. re #6177
Changeset: b99ba46c255d3b50896bfcca957abe40bcc43115
comment:87 Changed 7 years ago by Gesner Passos
Remove useless code of ScriptRepositoryImpl
re #6177
Changeset: c225ed535b2aeda14edf99517bf9486de7525b00
comment:88 Changed 7 years ago by Gesner Passos
Add support for Upload from the User Interaction point of view
re #6177
Changeset: 84d6068fa2c6824ca2d6931d981a7445d89dbe08
comment:89 Changed 7 years ago by Gesner Passos
comment:90 Changed 7 years ago by Gesner Passos
Handle exceptions RepoModel
Allow the RepoModel to handle download/upload exceptions and inform the the reason.
re #6177
Changeset: aea75884d665f086f8784a4151aa506634be0236
comment:91 Changed 7 years ago by Gesner Passos
Improve the information of some exceptions
re #6177
Changeset: 9caff91cf930960ec7b0b50a465bc077284e8cf8
comment:92 Changed 7 years ago by Gesner Passos
comment:93 Changed 7 years ago by Gesner Passos
Does not create an empty file when download fails.
re #6177
Changeset: 3c0b70dce81079ef87256eabc92d39b953aaa5a0
comment:94 Changed 7 years ago by Gesner Passos
Correct the ScriptRepositoryTest to not change the properties
When the unittest is executed it should not change the configured user property. Add also a new unit test to ensure that folder has correct status after download.
re #6177
Changeset: fd11b9f79709eac454ec9a276d58cdd91b1384f0
comment:95 Changed 7 years ago by Gesner Passos
Correct the installation of ScriptRepository
It is possible to install the ScriptRepository at the same path of a previous installation.
re #6177
Changeset: df1bc890316d51ebbd48964daa8e06d9343666df
comment:96 Changed 7 years ago by Gesner Passos
Ensure model is correctly created to create widget
re #6177
Changeset: dd10a2cffe746465c9f18dd1f31e41834d36daa6
comment:97 Changed 7 years ago by Gesner Passos
comment:98 Changed 7 years ago by Gesner Passos
Small changes to the ScriptRepository interface for improvement
Attempt to improve the interface for the sake of performance. Otherwise, plenty of copy of strings will be made that are useless.
re #6177
Changeset: 2c291ece8559905907f15f6f001a5cad3654f5fb
comment:99 Changed 7 years ago by Gesner Passos
Implementation of RepoModel
It fits the requirement of QAbstractItemModel
re #6177
Changeset: 2394e42563270044963240d5c30a7bb7bec5956c
comment:100 Changed 7 years ago by Gesner Passos
comment:101 Changed 7 years ago by Gesner Passos
Add RepoTreeView class
Just header class, its intention is to make known that the current selection of has changed. This is usefull to display the correct metainformation of the entries.
re #6177
Changeset: 81a384f52b12564a7db467fef3c24f3258558e76
comment:102 Changed 7 years ago by Gesner Passos
Introduction of ScriptRepositoryView
The class responsible for the UserInterface of ScriptRepository
re #6177
Changeset: b811db12302c2b4eba9e5bb6a2008a830d99afa6
comment:103 Changed 7 years ago by Gesner Passos
Correct a bug introduced
The commit http://trac.mantidproject.org/mantid/changeset/2c291ece8559905907f15f6f001a5cad3654f5fb/ has introduced a bug, that does not update the status of a downloaded directory.
This solves the issue. re #6177
Changeset: b99ba46c255d3b50896bfcca957abe40bcc43115
comment:104 Changed 7 years ago by Gesner Passos
Remove useless code of ScriptRepositoryImpl
re #6177
Changeset: c225ed535b2aeda14edf99517bf9486de7525b00
comment:105 Changed 7 years ago by Gesner Passos
Add support for Upload from the User Interaction point of view
re #6177
Changeset: 84d6068fa2c6824ca2d6931d981a7445d89dbe08
comment:106 Changed 7 years ago by Gesner Passos
comment:107 Changed 7 years ago by Gesner Passos
Handle exceptions RepoModel
Allow the RepoModel to handle download/upload exceptions and inform the the reason.
re #6177
Changeset: aea75884d665f086f8784a4151aa506634be0236
comment:108 Changed 7 years ago by Gesner Passos
Improve the information of some exceptions
re #6177
Changeset: 9caff91cf930960ec7b0b50a465bc077284e8cf8
comment:109 Changed 7 years ago by Gesner Passos
comment:110 Changed 7 years ago by Gesner Passos
Does not create an empty file when download fails.
re #6177
Changeset: 3c0b70dce81079ef87256eabc92d39b953aaa5a0
comment:111 Changed 7 years ago by Gesner Passos
Correct the ScriptRepositoryTest to not change the properties
When the unittest is executed it should not change the configured user property. Add also a new unit test to ensure that folder has correct status after download.
re #6177
Changeset: fd11b9f79709eac454ec9a276d58cdd91b1384f0
comment:112 Changed 7 years ago by Gesner Passos
Correct the installation of ScriptRepository
It is possible to install the ScriptRepository at the same path of a previous installation.
re #6177
Changeset: df1bc890316d51ebbd48964daa8e06d9343666df
comment:113 Changed 7 years ago by Gesner Passos
Ensure model is correctly created to create widget
re #6177
Changeset: dd10a2cffe746465c9f18dd1f31e41834d36daa6
comment:114 Changed 7 years ago by Gesner Passos
comment:115 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7023
