Ticket #6183 (new)
Adjust existing definitions to use locations tag
Reported by: | Nick Draper | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | minor | Milestone: | Backlog |
Component: | Framework | Keywords: | Maintenance |
Cc: | Blocked By: | ||
Blocking: | Tester: |
Description
Change History
comment:4 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:5 Changed 7 years ago by Nick Draper
- Status changed from new to infoneeded
Please assess if ticket is still valid and add a description to the ticket
comment:6 Changed 7 years ago by Anders Markvardsen
- Priority changed from major to minor
- Keywords Maintenance added
This was meant as a maintenance ticket.
Many of the IDFs could likely become a lot shorter by using the <locations> tag to replace equilly spaced <location> tags.
At this point I have done this for LET, which described here, http://www.mantidproject.org/IDF#Using_.3Clocations.3E , reduced IDF from 1590 to 567 lines.
It is not a high priority, and perhaps rather than doing a mass conversion of all IDFs as suggested with this ticket, just convert IDF on case by case basis and where users can benefit from a shorter IDF.
Hence, writing this I am indifferent as to whether or not to close this ticket.
comment:7 Changed 7 years ago by Arturs Bekasovs
While working on #9136, I've found another example of potential space for improvements. It's the MUSR definition:
<type name="ring-front"> <component type="pixel"> <location r="0.14" t="90" p="309.375000" rot="309.375000" name="det33"/> <location r="0.14" t="90" p="298.125000" rot="298.125000" name="det34"/> <location r="0.14" t="90" p="286.875000" rot="286.875000" name="det35"/> ... more lines ... <location r="0.14" t="90" p="28.125000" rot="28.125000" name="det58"/> <location r="0.14" t="90" p="16.875000" rot="16.875000" name="det59"/> <location r="0.14" t="90" p="5.625000" rot="5.625000" name="det60"/> <location r="0.14" t="90" p="354.375000" rot="354.375000" name="det61"/> <location r="0.14" t="90" p="343.125000" rot="343.125000" name="det62"/> <location r="0.14" t="90" p="331.875000" rot="331.875000" name="det63"/> <location r="0.14" t="90" p="320.625000" rot="320.625000" name="det64"/> </component> </type>
This might be replaced with much shorter (and consequently less error-prone):
<type name="ring-front"> <component type="pixel"> <locations r="0.14" t="90" p="309.375000" p-end="5.625000" rot="309.375000" rot-end="5.625000" name="det" n-elements="28" name-count-start="33"/> <locations r="0.14" t="90" p="354.375000" p-end="320.625000" rot="354.375000" rot-end="320.625000" name="det" n-elements="4" name-count-start="61"/> </component> </type>
I believe that EMU, ARGUS and HIFI have similar structures as well.
Moved at the code freeze for release 2.4