Ticket #6185 (closed: fixed)
Extend DetermineChunking for other workspace types
| Reported by: | Nick Draper | Owned by: | Vickie Lynch |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
Currently it only works for eventworkspaces
Change History
comment:2 Changed 8 years ago by Vickie Lynch
Refs #6185 DetermineChunking for ISIS raw files
Changeset: ec800e1099192d0de6a6ab6d7c27264548fa8590
comment:3 Changed 8 years ago by Vickie Lynch
Refs #6185 DetermineChunking for SNS histo.nxs
Changeset: 24e1712a1c1f01be7c84df9b891a8ba45addcb93
comment:4 Changed 8 years ago by Vickie Lynch
Refs #6185 chunking working for LoadTOFRawNexus
Changeset: e45cd4b68849a68b2c10ec91d94c469b1dd65eb6
comment:5 Changed 8 years ago by Vickie Lynch
Refs #6185 fix chunk beginning in middle of bank
Changeset: c2a6d91ddffbcc6b866ac324e01d6442813442ed
comment:6 Changed 8 years ago by Vickie Lynch
- Status changed from accepted to verify
- Resolution set to fixed
Chunking is implemented for LoadRaw and LoadTOFRawNexus. SNSPowderReduction does the reduction in chunks for histograms, but does not reduce the memory size to that of the chunk. This could be accomplished if MantidVec was changed to be boost sparse vectors.
comment:7 Changed 8 years ago by Vickie Lynch
Refs #6185 DetermineChunking for ISIS raw files
Changeset: 6e5fb0435310de13f867a7637d0e2a4b8b29fa8a
comment:8 Changed 8 years ago by Vickie Lynch
Refs #6185 DetermineChunking for SNS histo.nxs
Changeset: 49678686f292b0167aae57d80d266f3d136b2788
comment:9 Changed 8 years ago by Vickie Lynch
Refs #6185 chunking working for LoadTOFRawNexus
Changeset: 4edee31ee01d07d66b846b0223a528bf5b0b3d17
comment:10 Changed 8 years ago by Vickie Lynch
Refs #6185 fix chunk beginning in middle of bank
Changeset: d8c87cf945b8e646ccded59924421a16a0d71e20
comment:12 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:13 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to reopened
- Resolution fixed deleted
Works as expected for the supported file types but it would be better if it threw an error for unsupported formats rather than just creating an empty table.
The setWikiSummary/setOptionalMessage also don't mention the new file types.
comment:15 Changed 8 years ago by Vickie Lynch
Refs #6185 throws for unsupported file type
Changeset: d06cce49268c2ac761bcc754e0163c4b3a3b43e8
comment:16 Changed 8 years ago by Vickie Lynch
- Status changed from accepted to verify
- Resolution set to fixed
comment:18 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to reopened
- Resolution fixed deleted
Confirmed exception is thrown for unsupported types.
Sorry to be pedantic but could you just update the text in the setWikiSummary/setOptionalMessage strings to mention the additional formats?
comment:20 Changed 8 years ago by Vickie Lynch
Refs #6185 change wiki and optional message strings
Changeset: 053b55b6a7177989a5366e2655f367444fa724b9
comment:21 Changed 8 years ago by Vickie Lynch
- Status changed from accepted to verify
- Resolution set to fixed
comment:23 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
Thanks, looks good now.
comment:24 Changed 8 years ago by Vickie Lynch
Refs #6185 throws for unsupported file type
Changeset: d06cce49268c2ac761bcc754e0163c4b3a3b43e8
comment:25 Changed 8 years ago by Vickie Lynch
Refs #6185 change wiki and optional message strings
Changeset: 053b55b6a7177989a5366e2655f367444fa724b9
comment:26 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7031
