Ticket #6203 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Logging for algorithms that process groups does not follow parent

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

If you run an algorithm that does not have a special processGroups method on a group workspace then it simply runs the algorithm multiple times on each member. This behaviour is correct.

However, if you turn the logging off for the main algorithm the "child" algorithms do not follow suit and logging is still observed.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

Ensure logging follows main alg when processing groups. Refs #6203

Changeset: 7215d117bc997993ba8dfa24d456d8feddab41a8

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

To the tester: This script would produce the usual logging output before this change, now it should be pretty quiet.

from mantid.api import *

def run_algorithm(name, logging, **kwargs):
    alg = AlgorithmManager.createUnmanaged(name)
    alg.initialize()
    alg.setLogging(logging)
    for key, value in kwargs.iteritems():
        alg.setProperty(key, value)
    alg.execute()
    return alg

#===================================================================

run_algorithm('LoadRaw',logging=False,
              OutputWorkspace='ws',Filename='CSP79590.raw')

run_algorithm('CropWorkspace', logging=False,
              InputWorkspace='ws',OutputWorkspace='ws',XMax=600)

comment:3 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: There is still a message from LogParser. A separate ticket, [6205] has been created about this issue.

comment:4 Changed 8 years ago by Martyn Gigg

Ensure logging follows main alg when processing groups. Refs #6203

Changeset: 7215d117bc997993ba8dfa24d456d8feddab41a8

comment:5 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:6 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Couldn't see any logging.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7049

Note: See TracTickets for help on using tickets.